From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Richard Hansen Newsgroups: gmane.emacs.bugs,gmane.emacs.devel Subject: bug#55719: [PATCH] bindat strz fixes Date: Wed, 1 Jun 2022 16:29:14 -0400 Message-ID: <4d484c25-5bea-6bef-0f21-764ec078d3b6@rhansen.org> References: <6b1670d3-ae69-7f95-0e7d-d7cee0763c4a@rhansen.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7968"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Cc: 55719@debbugs.gnu.org, emacs-devel@gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 01 22:31:45 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nwV0K-0001tt-1w for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jun 2022 22:31:44 +0200 Original-Received: from localhost ([::1]:50270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nwV0I-0002l1-L9 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 01 Jun 2022 16:31:42 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52400) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nwUyi-0002je-81 for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2022 16:30:04 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58093) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nwUyh-0001cQ-Eo for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2022 16:30:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nwUyh-0007b3-9H for bug-gnu-emacs@gnu.org; Wed, 01 Jun 2022 16:30:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Richard Hansen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 01 Jun 2022 20:30:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55719 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 55719-submit@debbugs.gnu.org id=B55719.165411535729095 (code B ref 55719); Wed, 01 Jun 2022 20:30:03 +0000 Original-Received: (at 55719) by debbugs.gnu.org; 1 Jun 2022 20:29:17 +0000 Original-Received: from localhost ([127.0.0.1]:51989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwUxx-0007ZD-Ej for submit@debbugs.gnu.org; Wed, 01 Jun 2022 16:29:17 -0400 Original-Received: from spork.scientician.org ([66.228.35.160]:48914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nwUxv-0007Yy-Tq for 55719@debbugs.gnu.org; Wed, 01 Jun 2022 16:29:16 -0400 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 8307C4A1AC DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1654115355; bh=9lwT5IspCCq9qKtB31yNxiXNXKDfQhIUX2etPRRtNjU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=foQ06oMTKslrnxRYKih/hKguJVNJOrvnJ0ZMtQPyFQuCyEmpjGfdwQVJL2DdSxmEW LrQKKJ/hRxXp1PZCR+Ttwfp2c6wCE+Th+I18RqI0u13hwM0bjxanrnO5HYtTGizUNY 96n3ohmOoJACN3PWxASn+aow8os1McLlzCptYMF4= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id A51F9201B8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1654115353; bh=9lwT5IspCCq9qKtB31yNxiXNXKDfQhIUX2etPRRtNjU=; h=Date:Subject:From:To:Cc:References:In-Reply-To:From; b=DawDHJCEROEa+ckEab6gHULkGk9CANEsR0m2jxAittqHXlk2VI8a2AEsoQMLWU+la kRi6RQzFVn3CyjfPaAnQF6XmNFNHKpsJ0NgwvsIVp7MNIGzY4j+sRfddltPjFBdH1k rW0BY2++zmvJzu/4Ukq2KrX6R0xd4P1sjknBZiaQ= Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:233513 gmane.emacs.devel:290533 Archived-At: On 6/1/22 16:23, Richard Hansen wrote: > Anyone that needs the current behavior should be using `str N`, not > `strz N`. If they're using `strz N`, then I would consider that to be > a bug in their code. If this change breaks someone, they can fix it > easily: just change `strz N` to `str N`. I understand that we should > endeavor to maintain compatibility, but keeping the current behavior > would be intentionally preserving a bug to accommodate other bugs. I > don't think that's a good trade-off. Actually I'm wrong; there is a difference between `str N` and `strz N`. With `str N`, all zero bytes in the input string are included in the unpacked value (including trailing null bytes). With `strz N`, the unpacked string ends just before the first zero byte. I'll remove the `strz N` change from the patch series so that we can get the rest merged.