From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#41890: 28.0.50; [PATCH]: Add bindings for project.el Date: Wed, 17 Jun 2020 01:47:53 +0300 Message-ID: <4d121083-7d88-6247-cc4e-0bcc19084928@yandex.ru> References: <87blljbarq.fsf@thornhill.no> <83pn9z13xq.fsf@gnu.org> <87lfknklj8.fsf@thornhill.no> <83h7vb0w3u.fsf@gnu.org> <87ftaulxzr.fsf@thornhill.no> <87r1ueri7m.fsf@tcd.ie> <87imfqn829.fsf@thornhill.no> <87ftaun7ug.fsf@thornhill.no> <87v9jqfzbv.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="20319"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 Cc: "Basil L. Contovounesios" , 41890@debbugs.gnu.org To: Juri Linkov , Theodor Thornhill Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jun 17 00:49:16 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jlKOJ-0005B3-1a for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 17 Jun 2020 00:49:15 +0200 Original-Received: from localhost ([::1]:37732 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jlKOI-0004XE-33 for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 16 Jun 2020 18:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:48952) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jlKO6-0004X4-AM for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 18:49:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:38304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jlKO6-0002vw-1Y for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 18:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jlKO5-00069F-Sv for bug-gnu-emacs@gnu.org; Tue, 16 Jun 2020 18:49:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 16 Jun 2020 22:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41890 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 41890-submit@debbugs.gnu.org id=B41890.159234768323565 (code B ref 41890); Tue, 16 Jun 2020 22:49:01 +0000 Original-Received: (at 41890) by debbugs.gnu.org; 16 Jun 2020 22:48:03 +0000 Original-Received: from localhost ([127.0.0.1]:49850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKN9-000681-8U for submit@debbugs.gnu.org; Tue, 16 Jun 2020 18:48:03 -0400 Original-Received: from mail-wr1-f53.google.com ([209.85.221.53]:39519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jlKN7-00067X-Hv for 41890@debbugs.gnu.org; Tue, 16 Jun 2020 18:48:01 -0400 Original-Received: by mail-wr1-f53.google.com with SMTP id t18so309233wru.6 for <41890@debbugs.gnu.org>; Tue, 16 Jun 2020 15:48:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=aUW1rUsYJkzT+m9JY0336R0Xc10IQ48Xz3skzSTJ8gc=; b=AqkH4NdfACpfwHssosAATG0CC50LghqqjHAsj7ouJ7Tic9clxIxlaNhdTc8Vtr1Hqk 3DTxEFt87mIW7W0q378WQ8jBo5Fxa7r41QYuuIQREz5dJ46QUiqsF4Dgz+7OVIF1sCyc cQASligXeEZ53jEgPXdIDeEmf589HJxEU90AY+kTOO/bwm7+7MZMuv9Vv8nGh6TtF7zN +nTv2VEjN6ivGXxCXY5DnYWrjtaqmHXZgkftY1r7n8ioMFW3hXETkLzPKYNhn872QbwY uRsk2KVqPX3jshPYFHp2B4rAZg7GCnJcO0Ymxd4fOWqS4GX/y+c99alzSSTqz7MNVwJg uSFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=aUW1rUsYJkzT+m9JY0336R0Xc10IQ48Xz3skzSTJ8gc=; b=QH0zg2qX2yEfsxXUKdGWF+WOfr/Cu6vs7IrS0HvGKQ5LWLplN5doIEx+zmQQBMpAXg lKnNMVyuBN/Ng+KeizcZp4grq7lt/e1U/1GmoH89Z7sRyPntsQWmbX+O0DOEMi7AmltE o0FkEq4dzUV//ZLTXFeFZcWdN2czlWpq4OgMODL9w2Dh1w2T+9k+p7f4EAOHTmBY7h7h 5iS6+3s3Wy7bExUvLWCmdplGmtIoKd9lWTFIZz9qqVy3tUw7w9GFBDc7yzpADo4DfIqR kcw+wNHyl/uz8seMIWPm814CdS0i2eZ46auh6WdZLrbTTcusAIfwe/fs6uM+kEFf6EkE bouA== X-Gm-Message-State: AOAM530/jmK9thopDTTm8Q7i6YwpgRdCXK31qq5nVsarJieTJBMWPztf exayrGSb4hcFy9EAhmP4XNRtRShC X-Google-Smtp-Source: ABdhPJzZZGm0RrQqZsc+eakk9qsHAVhMbiRVkuW83MMCB4Iyfh3zgihsFRqC0tATX9u2GYdkzZ05ag== X-Received: by 2002:a5d:6a03:: with SMTP id m3mr5167069wru.293.1592347675402; Tue, 16 Jun 2020 15:47:55 -0700 (PDT) Original-Received: from [192.168.0.3] ([66.205.73.129]) by smtp.googlemail.com with ESMTPSA id o82sm6034275wmo.40.2020.06.16.15.47.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 16 Jun 2020 15:47:54 -0700 (PDT) In-Reply-To: <87v9jqfzbv.fsf@mail.linkov.net> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182057 Archived-At: On 17.06.2020 00:57, Juri Linkov wrote: >> + (define-key map "f" 'project-find-file) >> + (define-key map "b" 'project-switch-to-buffer) >> + (define-key map "s" 'project-shell) >> + (define-key map "d" 'project-dired) >> + (define-key map "v" 'project-vc-dir) >> + (define-key map "c" 'project-compile) >> + (define-key map "e" 'project-eshell) >> + (define-key map "p" 'project-switch-project) >> + (define-key map "g" 'project-find-regexp) >> + (define-key map "r" 'project-query-replace-regexp) > > I think your choice of keys is better than in project-switch-commands. > Maybe these keys should be copied to project-switch-commands, so it will to be > in sync with project-prefix-map? I'll make sure to keep them compatible in the default setup. > Or is it possible to use project-prefix-map directly in project-switch-commands? > For example, by using set-transient-map? We discussed that with Simen in private previously. The current implementation is "visual", which is good for discoverability. I think that kind of limits us, however, to showing only the most "essential" commands (think: ones that the user is most likely to use right after switching to a different project), and not the whole set. Or else people will spend more time searching for the key they need to press. And they won't use most of the entries in the list anyway. For that reason also, I just removed the project-shell entry from that list because we haven't reached to solid conclusion WRT shell vs eshell, and yet it was time to do a release. FWIW, I'm fine with either option, but we probably don't need both in the list (we should be fine with having both in project-prefix-map, however). I also forgot to mention that in the commit message (3bff583). Sorry!