From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#28978: 26.0; Regression: separate, dedicated `*Completions*' frame no longer has parameter `minibuffer' Date: Tue, 24 Oct 2017 13:20:17 -0700 (PDT) Message-ID: <4d0c5535-246a-4356-914f-3c8d030ba9c9@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1508876485 23647 195.159.176.226 (24 Oct 2017 20:21:25 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 24 Oct 2017 20:21:25 +0000 (UTC) To: 28978@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 24 22:21:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e75hD-0003xh-5a for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Oct 2017 22:21:07 +0200 Original-Received: from localhost ([::1]:45390 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e75hK-0005Pr-AV for geb-bug-gnu-emacs@m.gmane.org; Tue, 24 Oct 2017 16:21:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e75hE-0005Pj-3h for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:21:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e75h9-0007Uw-0G for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:21:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51575) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e75h8-0007UP-PB for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:21:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e75h8-0002T5-H7 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 24 Oct 2017 20:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 28978 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.15088764389419 (code B ref -1); Tue, 24 Oct 2017 20:21:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 24 Oct 2017 20:20:38 +0000 Original-Received: from localhost ([127.0.0.1]:60256 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e75gk-0002Rq-9v for submit@debbugs.gnu.org; Tue, 24 Oct 2017 16:20:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:41341) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e75gi-0002Rf-MN for submit@debbugs.gnu.org; Tue, 24 Oct 2017 16:20:37 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e75gc-0006gM-6f for submit@debbugs.gnu.org; Tue, 24 Oct 2017 16:20:31 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:47004) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e75gc-0006g6-2R for submit@debbugs.gnu.org; Tue, 24 Oct 2017 16:20:30 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e75ga-0005N8-St for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:20:29 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e75gV-0006ZX-Qf for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:20:28 -0400 Original-Received: from aserp1040.oracle.com ([141.146.126.69]:18218) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1e75gV-0006V3-H2 for bug-gnu-emacs@gnu.org; Tue, 24 Oct 2017 16:20:23 -0400 Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by aserp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v9OKKJTX031321 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 24 Oct 2017 20:20:20 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id v9OKKJDR012860 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Tue, 24 Oct 2017 20:20:19 GMT Original-Received: from abhmp0008.oracle.com (abhmp0008.oracle.com [141.146.116.14]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v9OKKJR1011932 for ; Tue, 24 Oct 2017 20:20:19 GMT X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4600.0 (x86)] X-Source-IP: userv0021.oracle.com [156.151.31.71] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.4.x-2.6.x [generic] [fuzzy] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138931 Archived-At: In my code I check (essentially) this: (let ((swin (selected-window))) (when (window-minibuffer-p swin) (setq swin (minibuffer-selected-window)= )) (and (get-buffer-window "*Completions*") (window-live-p swin) (not (eq (window-buffer swin) (get-buffer "*Completions*"))) (interactive-p))) It does what I expect in all Emacs releases, but not in this prerelease. My `*Completions*' window is in its own one-window frame, with the window dedicated. Input for that frame is redirected to my standalone minibuffer frame. It should be the case in my context that this returns the minibuffer window: (cdr (assoc 'minibuffer (frame-parameters (#)))) Instead, it now returns nil. Parameter `minibuffer' for the `*Completions*' frame is no longer the minibuffer window; it is nil. This is the code that redirects the frame focus, which I guess is relevant: (let ((redirect (if (active-minibuffer-window) 1on1-minibuffer-frame (and completion-reference-buffer (get-buffer-window completion-reference-buffer 'vis= ible) (not (eq (get-buffer "*Completions*") completion-re= ference-buffer)) (window-frame (get-buffer-window completion-referen= ce-buffer t)))))) (when redirect (redirect-frame-focus (selected-frame) redirect))) That code is in a function, `1on1-display-*Completions*-frame', that I use with `special-display-buffer-names': (add-to-list 'special-display-buffer-names `("*Completions*" 1on1-display-*Completions*-frame ((background-color ,@1on1-completions-frame-background) (mouse-color ,@1on1-completions-frame-mouse+cursor-col= or) (cursor-color ,@1on1-completions-frame-mouse+cursor-col= or) (menu-bar-lines . 0) (tool-bar-lines . 0) ; No menu bar or = tool bar. ,@(and 1on1-completions-frame-width `((width ,@1on1-completions-frame-width)))))) In GNU Emacs 26.0.90 (build 3, x86_64-w64-mingw32) of 2017-10-13 Repository revision: 906224eba147bdfc0514090064e8e8f53160f1d4 Windowing system distributor `Microsoft Corp.', version 6.1.7601 Configured using: `configure --without-dbus --host=3Dx86_64-w64-mingw32 --without-compress-install 'CFLAGS=3D-O2 -static -g3''