From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70362: [PATCH] Add font-locking for Go built-in functions in go-ts-mode Date: Sat, 13 Apr 2024 15:16:45 +0300 Message-ID: <4ca70f75-4834-4299-ab6d-4621dde31cfe@gutov.dev> References: <86plutraj0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23017"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70362@debbugs.gnu.org To: Noah Peart , Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 13 14:18:12 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rvcKg-0005gk-Rf for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 13 Apr 2024 14:18:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rvcKT-0008OO-2O; Sat, 13 Apr 2024 08:17:57 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rvcKO-0008GJ-P2 for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 08:17:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rvcKO-0001qa-9R for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 08:17:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rvcKY-0003O1-8N for bug-gnu-emacs@gnu.org; Sat, 13 Apr 2024 08:18:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 13 Apr 2024 12:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70362 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 70362-submit@debbugs.gnu.org id=B70362.171301063612602 (code B ref 70362); Sat, 13 Apr 2024 12:18:02 +0000 Original-Received: (at 70362) by debbugs.gnu.org; 13 Apr 2024 12:17:16 +0000 Original-Received: from localhost ([127.0.0.1]:60287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvcJk-0003Gb-GH for submit@debbugs.gnu.org; Sat, 13 Apr 2024 08:17:16 -0400 Original-Received: from wfout6-smtp.messagingengine.com ([64.147.123.149]:47579) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rvcJe-0003EG-Vz for 70362@debbugs.gnu.org; Sat, 13 Apr 2024 08:17:10 -0400 Original-Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailfout.west.internal (Postfix) with ESMTP id 43C321C0013B; Sat, 13 Apr 2024 08:16:50 -0400 (EDT) Original-Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sat, 13 Apr 2024 08:16:50 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1713010609; x=1713097009; bh=1Sn3AENJo3x/ID82ezW+xoN7GvCfTwTGxkcpdSOTmUk=; b= OYonMryeO7KRPH6K+mO8PA2b6Wp/q6HEbgGBHTfuP2XH2UpCDQKhEb5zqQnn5xgg b/5Tvi5AQ0UmnCj7XsfzX633yR8RPLr8FKh2YuC6wZRi5PCLH01zXBxRS/FsbEqc 1h2PED01B7KR3bnPVU0A7L50+RamwmWdgq4SGbqVDq2G1sEtkCIdoqWzpfRoSiGN t3VSpoEpceSPaq/0X5OpzbFr1wsaMyVIbVtm2LH04/WCrGVd7dN5Ga+wWFeL37Sj 1T63dh1z/gRZQbaYtd/FoUXqdxgATze2w0bEVnRZbwqaxy8Zb7ZNoyuO5ApI7eky FgSxCfrQ6RGUWqtRXEgDqw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1713010609; x= 1713097009; bh=1Sn3AENJo3x/ID82ezW+xoN7GvCfTwTGxkcpdSOTmUk=; b=n XVftUg2dNGIKjb/A/D2OpBLoPwHH5PAEcowe2zf5j2hxusGnBHpBfKLoslqWBFgD KVMoKT5d2Lfj3lcUxR7g5jnITZLPkLtJia0bseIHopEt8wqzdiWHQFxR4zFWeb2n Qufzc/SukwA55IIx4P39egeX9wOt/kbk/3fduoU2jC3sZjRDOwMfdgAe6w35/3RT 54nzfml36fmoqCRGDtFCHC7nXEPV/9X0DDakkXu/cgYori/Rsj4KHmLqHFZoDQL4 xqSYv1y+7vdsUUK+b47GGqZ/O5gA1t43owRzK6m9XDRTjo3dSFwk+qcRpX4h8oaf TI7g7bZb5kR18+lNP0qFg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudeiiedghedtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 13 Apr 2024 08:16:48 -0400 (EDT) Content-Language: en-US In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283211 Archived-At: On 13/04/2024 10:40, Noah Peart wrote: > I put it at level 3 following the conventions in other treesit modes > I checked: python-ts-mode, ruby-ts-mode, rust-ts-mode all put builtins > at level 3. > But, I haven't done a full census of the ts modes so there might be > variability. SGTM. If classic major modes highlight a thing (and they do that for built-ins), we usually put it in the default highlighting for ts modes as well (meaning level 3 or lower).