From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#23007: 24.5; buggy interactive search with middle click Date: Mon, 29 May 2017 18:07:49 -0700 (PDT) Message-ID: <4b54dcb3-c907-4edd-aaaf-d1e9088f97f3@default> References: <87a8m13gba.fsf@zira.vinc17.org> <871sr7h1xy.fsf@gmail.com> <87inkj43q9.fsf@users.sourceforge.net> <3858231a-8ba1-47a7-a4fa-f516ea1eba22@default> <87d1ar412z.fsf@users.sourceforge.net> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1496106493 24054 195.159.176.226 (30 May 2017 01:08:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 30 May 2017 01:08:13 +0000 (UTC) Cc: Vincent Lefevre , Alex , 23007@debbugs.gnu.org To: npostavs@users.sourceforge.net Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 30 03:08:06 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFVdm-00064C-6k for geb-bug-gnu-emacs@m.gmane.org; Tue, 30 May 2017 03:08:06 +0200 Original-Received: from localhost ([::1]:51050 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFVdr-0005VM-Ac for geb-bug-gnu-emacs@m.gmane.org; Mon, 29 May 2017 21:08:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dFVdl-0005VG-QC for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 21:08:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dFVdi-00007z-Lb for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 21:08:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41299) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dFVdi-00007u-Hk for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 21:08:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dFVdi-0008TY-Bl for bug-gnu-emacs@gnu.org; Mon, 29 May 2017 21:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 30 May 2017 01:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23007 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23007-submit@debbugs.gnu.org id=B23007.149610648132574 (code B ref 23007); Tue, 30 May 2017 01:08:02 +0000 Original-Received: (at 23007) by debbugs.gnu.org; 30 May 2017 01:08:01 +0000 Original-Received: from localhost ([127.0.0.1]:43976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFVdh-0008TJ-1B for submit@debbugs.gnu.org; Mon, 29 May 2017 21:08:01 -0400 Original-Received: from userp1040.oracle.com ([156.151.31.81]:49769) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dFVdf-0008T6-57 for 23007@debbugs.gnu.org; Mon, 29 May 2017 21:07:59 -0400 Original-Received: from userv0022.oracle.com (userv0022.oracle.com [156.151.31.74]) by userp1040.oracle.com (Sentrion-MTA-4.3.2/Sentrion-MTA-4.3.2) with ESMTP id v4U17p92023039 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 May 2017 01:07:51 GMT Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0022.oracle.com (8.14.4/8.14.4) with ESMTP id v4U17pdK019930 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 30 May 2017 01:07:51 GMT Original-Received: from abhmp0004.oracle.com (abhmp0004.oracle.com [141.146.116.10]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id v4U17omf017106; Tue, 30 May 2017 01:07:50 GMT In-Reply-To: <87d1ar412z.fsf@users.sourceforge.net> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 12.0.6767.5000 (x86)] X-Source-IP: userv0022.oracle.com [156.151.31.74] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:133029 Archived-At: > >> > + (let ((overriding-terminal-local-map nil)) > >> > + (setq binding (key-binding (this-command-keys-vector) t))) > >> > >> IMO, it would be better style to do something like > >> > >> (let ((binding (let ((overriding-terminal-local-map nil)) > >> (key-binding (this-command-keys-vector) t)))) > >> ...) > > > > (let* ((overriding-terminal-local-map nil) > > (binding (key-binding (this-command-keys-vector) t))) > > ...) >=20 > Check https://urldefense.proofpoint.com/v2/url?u=3Dhttps- > 3A__debbugs.gnu.org_cgi_bugreport.cgi-3Fbug-3D23007- > 238&d=3DDwIBAg&c=3DRoP1YumCXCgaWHvlZYR8PQcxBKCX5YTpkKY057SbK10&r=3DqZLZos= Y6GBAaJtO > G9v8QX7nD4BS9t9s5otgxC3d4IFU&m=3DeZ-Uw6bQQfS-_CFDf_e3zupcjOhlrCnDnq5pNm6- > bao&s=3De0BQOMr3F7kitlASNZ_EMEy-LvwMn0CsRuZUecvrYZg&e=3D , we need to > avoid binding `overriding-terminal-local-map' in "...". Clearly I, like you, meant that this let is for only the second `if' clause. But these are only style differences. If it were I, I'd also move the let-binding that is used only in the first `if' clause into the `if' test. (And I'd ensure that there is in fact a mark.) (if (let ((win (posn-window (event-start click)))) (and (window-minibuffer-p win) (not (minibuffer-window-active-p win)) (mark))) (isearch-yank-x-selection) (let* ((overriding-terminal-local-map nil) (binding (key-binding (this-command-keys-vector) t))) (when (functionp binding) (call-interactively binding))))