From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#65356: 30.0.50; [wishlist] Support Tramp method, user name and host name completion in eshell Date: Thu, 17 Aug 2023 20:31:54 -0700 Message-ID: <4b4a64de-846a-ed2a-f409-80ea75e9cb57@gmail.com> References: <87r0o1r1io.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21065"; mail-complaints-to="usenet@ciao.gmane.io" Cc: monnier@iro.umontreal.ca To: Michael Albinus , 65356@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Aug 18 05:33:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qWqEl-0005Ip-IA for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Aug 2023 05:33:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qWqES-00013T-78; Thu, 17 Aug 2023 23:33:04 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qWqER-00013K-3B for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 23:33:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qWqEQ-0004kG-Qo for bug-gnu-emacs@gnu.org; Thu, 17 Aug 2023 23:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qWqEP-0001Cv-UI; Thu, 17 Aug 2023 23:33:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: monnier@iro.umontreal.ca, bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Aug 2023 03:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65356 X-GNU-PR-Package: emacs X-Debbugs-Original-Xcc: monnier@iro.umontreal.ca Original-Received: via spool by 65356-submit@debbugs.gnu.org id=B65356.16923295274574 (code B ref 65356); Fri, 18 Aug 2023 03:33:01 +0000 Original-Received: (at 65356) by debbugs.gnu.org; 18 Aug 2023 03:32:07 +0000 Original-Received: from localhost ([127.0.0.1]:45818 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWqDW-0001Bh-Lv for submit@debbugs.gnu.org; Thu, 17 Aug 2023 23:32:06 -0400 Original-Received: from mail-pl1-x62f.google.com ([2607:f8b0:4864:20::62f]:56529) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qWqDS-0001BA-3g for 65356@debbugs.gnu.org; Thu, 17 Aug 2023 23:32:05 -0400 Original-Received: by mail-pl1-x62f.google.com with SMTP id d9443c01a7336-1bc8a2f71eeso3792625ad.0 for <65356@debbugs.gnu.org>; Thu, 17 Aug 2023 20:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1692329516; x=1692934316; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=Zktv2YcNvhODSC6oOBH/7CIXwc9xJJkdkwucoXJOvmE=; b=GUYizW2JwIhhesDTLRtYE4UBkKKwi9lfTcwDODlS2DzhdEpQ1hduKcu/n69FDetOzV PDufTDSMCUlIP4hrA/EOqIKKYMRF87nJwBLOJ2OLyCWXPxeNhdRU92d4fgXpMWvzyXpn Vys8Iy0S/fuJu8QcJMztLvSAyVTKWDsKNWm4O2p5aBv7kYRTfSHXXAh1TLcL6iD1h2Hz 48gdkDENXTC4HZ5wCxU3LGj2JLjM/CdmT6sUl+Od2EyDnPtzYLOlwbpRB2bV+KLPCttU 68yov+ZLUofu+OZZxyRxeKMvUxP54AiutFQq2vxIHOPI0kFmRZh9gGCa91ctnFd8J50C QaVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692329516; x=1692934316; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Zktv2YcNvhODSC6oOBH/7CIXwc9xJJkdkwucoXJOvmE=; b=RBvVFvD2cYyNDAHJEiCz4N6LixgOcTV1QBhiybk4ZZkxSLaZIufEgpXaNnIqD1l1/L cqM+q5Vl8lM2eyfX7UsEaB51zZ4Q3DDRoNUsnUtWT+f8+KwJm98UJZVDm261B7J562j7 OtxAYrRKnu2aR+FwWJ+g5dP0CXLWrBh3pS5YOo1u6LiRB0Rmcp+ZwBB4x2KcPACGHRR0 ZMRe3cp1Iww/p9NqoYo0AvLNSTM+VJ2SiLcUdEtYh/GRKmPlx2ANLYBpe2U8l2lAAy4T fF0/5Qv6unmVoLzi9lVC75fd7+X8f7imWwKDmrFXO6P7pmI6xhrJihKlhg0zaAYz7hNL j7cw== X-Gm-Message-State: AOJu0Yx59FQJ3lFkk2pWm86kkJqeJMXoSsBj+yP5ghpW3ghLn4JnawFE x8O7iaQP8DNPXO55RiFXZes= X-Google-Smtp-Source: AGHT+IFVACzhxg8+mFbVuIbBDiu1v03dT8aQRE2WbXQkkNREDBE2kyJNQeWMO14cSM3VYzeYrUyajQ== X-Received: by 2002:a17:902:ab49:b0:1bc:50f9:8f20 with SMTP id ij9-20020a170902ab4900b001bc50f98f20mr1232843plb.23.1692329515601; Thu, 17 Aug 2023 20:31:55 -0700 (PDT) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id l20-20020a170903005400b001bdcafcf8d3sm536763pla.69.2023.08.17.20.31.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Aug 2023 20:31:54 -0700 (PDT) Content-Language: en-US In-Reply-To: <87r0o1r1io.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:267706 Archived-At: X-Debbugs-Cc: monnier@iro.umontreal.ca On 8/17/2023 11:01 AM, Michael Albinus wrote: > In eshell, this feature does not exist. I would like if I could type > "cd /ss TAB" and could see the same offering of "ssh:", "sshfs:" and > "sshx:". Same for user name and host name. > > The appended patch does this for me. I have no idea how good it fits > into the eshell machinery, for example whether there are problems with > the em-elecslash.el module. Comments welcome! Thanks. This would be a useful feature indeed. I have a couple of main concerns, which I'm not quite sure what to do about at the moment: 1) Should this go in the Eshell Tramp extension module? Currently, that module is there to add built-in versions of su/sudo/doas, as an alternative to the "standard" Eshell way of connecting to a remote host: "cd /ssh:user@host:~". Therefore, I think we'd want tab-completion of Tramp file names even (or especially!) when the Tramp extension module is disabled (which is the default). 2) I'm not sure 'pcomplete-try-first-hook' is the right way to enable this. Pcomplete has quite a few ways of performing completions, and it already knows when it should specifically complete file names (as opposed to "--options" for example). Maybe we should enhance Pcomplete itself so that you can opt into completion of remote file names too? Then when you tab-complete in Eshell, it would just work in all the contexts where you can normally complete a file name. I Cc'ed Stefan since he might have some thoughts on the Pcomplete machinery here.