From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#70074: 29.1; js-ts-mode doesn't define comment-line-break-function Date: Fri, 5 Apr 2024 03:28:10 +0300 Message-ID: <4b3706a2-84d8-43c4-95bb-02d6f8c450b0@gutov.dev> References: <86msq971g0.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="40314"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla Thunderbird Cc: 70074@debbugs.gnu.org To: Eli Zaretskii , Evan Davis , Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Apr 05 02:29:30 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rsXST-000AG9-GP for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 Apr 2024 02:29:30 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rsXS2-0001x0-9i; Thu, 04 Apr 2024 20:29:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rsXRz-0001wA-16 for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 20:28:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rsXRy-0004ll-5g for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 20:28:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rsXS2-0001PK-Up for bug-gnu-emacs@gnu.org; Thu, 04 Apr 2024 20:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 Apr 2024 00:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70074 X-GNU-PR-Package: emacs Original-Received: via spool by 70074-submit@debbugs.gnu.org id=B70074.17122769105181 (code B ref 70074); Fri, 05 Apr 2024 00:29:02 +0000 Original-Received: (at 70074) by debbugs.gnu.org; 5 Apr 2024 00:28:30 +0000 Original-Received: from localhost ([127.0.0.1]:34965 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsXRV-0001LK-Aj for submit@debbugs.gnu.org; Thu, 04 Apr 2024 20:28:30 -0400 Original-Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:58953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rsXRS-0001KM-My for 70074@debbugs.gnu.org; Thu, 04 Apr 2024 20:28:27 -0400 Original-Received: from compute7.internal (compute7.nyi.internal [10.202.2.48]) by mailout.west.internal (Postfix) with ESMTP id F1373320094F; Thu, 4 Apr 2024 20:28:14 -0400 (EDT) Original-Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Thu, 04 Apr 2024 20:28:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm1; t=1712276894; x=1712363294; bh=gY/tz3dxodE18Fpl/3nDUrGSb245+1H8lU2+g+hxA3I=; b= wYXBrBmbqyoA3M0Y/8T/L00rcW5OoFtmOFR5wASdkhrgKh6XSC/OiyisQageCrXA YVXvZy5/tFQzsar0hO4WzqpxTVffVoOUVPnytm5gIYRMeCFqyNTHlRLib7a9szak xuyzRREEFOjj6S7r+IiJbRvx44ZPJj2hCRlxhhInm8nznaFeWVQTUWRt0QPVT4vd WAJE08yxYPAWmR/2UH19fRVSVHBaP14zAOinIJ6/MEDAelDmK3Y8MpxPwrVcmOAk caGQZ0bniXDLONwBtqnwdecDgbUKeq66knxWMcjzh1Hfd5p/m5+WE9McWnV+Yz/F VadBB0pR76/370Wuj97F6A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1712276894; x= 1712363294; bh=gY/tz3dxodE18Fpl/3nDUrGSb245+1H8lU2+g+hxA3I=; b=M e/UqDkYR22ZyCgYlglDoITdwhWkT2Nx191Ou51OFRpgHzrrDu/WmVaBP7CieE7cb /ICmwgvuZMH+29LKH9NzpDNqAPwzeUS0VEItj75MO1RZtvH6EynHDA/t99bYx5HF IntXGVrPrwKNkAL9ysIqGKv89I8wd7PxB6wuK1NaJrmiDejGntbKCO/UCfjUjWcK xlPOffFJJ+F7RtERrrmytqI0PQ7W2E0qE0K7/fIpy7+OqMMt1ZVvlIbTEbCnGPYS 0LceV+ZXd7tpq1jelEVc/aKumM4CoO/6zWL3+Wt1HVSVKp0Mu1RuBEUlWe7eFUa+ n7QmDuW6QXb6J0RB0b9yA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrudefledgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeffmhhi thhrhicuifhuthhovhcuoegumhhithhrhiesghhuthhovhdruggvvheqnecuggftrfgrth htvghrnhepteduleejgeehtefgheegjeekueehvdevieekueeftddvtdevfefhvdevgedu jeehnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepug hmihhtrhihsehguhhtohhvrdguvghv X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Original-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 4 Apr 2024 20:28:12 -0400 (EDT) Content-Language: en-US In-Reply-To: <86msq971g0.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:282682 Archived-At: On 04/04/2024 15:32, Eli Zaretskii wrote: >> From: Evan Davis >> Date: Fri, 29 Mar 2024 11:03:10 -0400 >> >> js-ts-mode and js-mode behave differently when calling default-indent-new-line (M-j) within a multiline >> comment. >> >> Observed behavior: >> - in js-mode, M-j calls c-indent-new-comment-line, which correctly inserts a newline, indented to the correct >> column and prefixed with '*' >> - in js-ts-mode, M-j calls comment-indent-new-line, which inserts an indented newline without the prefix. >> >> Expected behavior: >> Block comments should be handled the same in both modes. >> >> Steps to reproduce: >> 1. emacs -Q >> 2. open a scratch buffer in js-ts-mode and enter text (without quotes) "/*" >> 3. press M-j >> 4. observe newline is created without star prefix >> >> Follow the same steps in js-mode to observe the desired behavior. > Dmitry, Yuan: any comments or suggestions? I suppose following in js-mode's footsteps and reusing this part of CC Mode is the obvious solution. I haven't looked at the implementation closely enough to suggest something else, but it'd of course be nice to be able to provide a self-contained, shorter re-implementation instead.