From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll point off screen temporarily Date: Tue, 4 Dec 2018 12:46:51 -0800 (PST) Message-ID: <4b2833f5-a0d7-408d-8cc0-4479043ef368@default> References: <51df60b6-e152-4989-a27e-70dadb9b7474@default> <8736rqgk6f.fsf@mail.linkov.net> <87y39gexdo.fsf@mail.linkov.net> <877egzmmyk.fsf@mail.linkov.net> <8af20443-841d-4211-99ae-269e042a9a33@default> <875zwidonq.fsf@mail.linkov.net> <178ca8ac-fb45-4cef-a48d-d916a60860be@default> <87a7lsu7rn.fsf@mail.linkov.net> <24e8fff5-67d8-49ac-801e-1e5f49d2037f@default> <875zwfed5h.fsf@mail.linkov.net> <5a6a3254-f742-44e9-a498-b6d5a375a873@default> <87va4ai16x.fsf@mail.linkov.net> <9a36d118-5ee8-4526-bc69-91665a8e801c@default> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1543956410 5102 195.159.176.226 (4 Dec 2018 20:46:50 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 4 Dec 2018 20:46:50 +0000 (UTC) Cc: 15839-done@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Dec 04 21:46:46 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUHad-0001Cz-Na for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2018 21:46:44 +0100 Original-Received: from localhost ([::1]:58924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUHck-000389-6e for geb-bug-gnu-emacs@m.gmane.org; Tue, 04 Dec 2018 15:48:54 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54115) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gUHby-0002FH-UW for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 15:48:08 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gUHbu-0001t5-Om for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 15:48:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56761) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gUHbu-0001sw-KZ for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 15:48:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gUHbu-0003KE-Hi for bug-gnu-emacs@gnu.org; Tue, 04 Dec 2018 15:48:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 04 Dec 2018 20:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15839 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15839-done@debbugs.gnu.org id=D15839.154395642212686 (code D ref 15839); Tue, 04 Dec 2018 20:48:02 +0000 Original-Received: (at 15839-done) by debbugs.gnu.org; 4 Dec 2018 20:47:02 +0000 Original-Received: from localhost ([127.0.0.1]:32780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUHav-0003IS-Rn for submit@debbugs.gnu.org; Tue, 04 Dec 2018 15:47:02 -0500 Original-Received: from userp2120.oracle.com ([156.151.31.85]:56234) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gUHat-0003IE-Ls for 15839-done@debbugs.gnu.org; Tue, 04 Dec 2018 15:47:00 -0500 Original-Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.22/8.16.0.22) with SMTP id wB4Kj2Bf063847; Tue, 4 Dec 2018 20:46:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2018-07-02; bh=tQ4yc6ZRdPUH56EwbeS6GW1ToCGnA8T5EV18hlM1hxU=; b=5rYbQCCYlFkh0+BCpnDGq5IJkB/n2ee7LyzfGIE4Ep5RpMx5ysJtxFUL3oav1/CioPxQ rS7ffJc4BqoJnOKYhlg/+K55aFrE+xg4o0Wt+TFlerZudNS9hNbsVE0/p9elm0XC46Ft bt0gzQ2L5BCxijWItZHpNkhSCw+VhD2eyS0FtHlaiPzgQPilT0PpN/4g0Cgv9Wmn15LK kFIP3KkwYuDlsFoHZ4gF25xy89hpK4y0sd9BY94O6Sbm/WnpSdK1YwVkVOR6n3Urw1JP Aep46wht23aWIbTPOkchUTi9zSFUJleLt7Eeu4q8cqlfV0E3yUZ8mnS9o3Tu1R9QFSrY fw== Original-Received: from userv0021.oracle.com (userv0021.oracle.com [156.151.31.71]) by userp2120.oracle.com with ESMTP id 2p3jxrer82-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 04 Dec 2018 20:46:53 +0000 Original-Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by userv0021.oracle.com (8.14.4/8.14.4) with ESMTP id wB4KkqR4002315 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 4 Dec 2018 20:46:53 GMT Original-Received: from abhmp0019.oracle.com (abhmp0019.oracle.com [141.146.116.25]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id wB4KkqdX016744; Tue, 4 Dec 2018 20:46:52 GMT In-Reply-To: <9a36d118-5ee8-4526-bc69-91665a8e801c@default> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4771.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=9097 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=994 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1812040178 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:153080 Archived-At: > -----Original Message----- > From: Drew Adams > Sent: Tuesday, December 4, 2018 6:46 AM > To: Juri Linkov > Cc: 15839-done@debbugs.gnu.org > Subject: bug#15839: 24.3.50; `isearch-allow-scroll': be able to scroll > point off screen temporarily >=20 > > > But I don't really need to understand. I reviewed > > > what you wrote about that only because you included > > > it in a reply to this (other) bug report. Ignore my > > > feedback about `*-allow-shift-selection' if you like > > > - no problem. > > > > Thank you for your feedback, all your remarks were > > taken into consideration, committed to master, and > > this enhancement request closed. >=20 > I'm amazed by this, Juri. You introduced stuff > into this bug thread that is about another bug > entirely (`*-allow-shift-selection'). >=20 > I replied to your feedback about this bug, point by > point. And, hoping to help, I also provided some > feedback about that other, unrelated bug. >=20 > What you quote above is about that _other_ bug, not > this one. I said that you can, if you like, ignore > my feedback about `*-allow-shift-selection'. That > bug is not something I'm really concerned about - > my feedback about it was just trying to be helpful. >=20 > As for this bug, I made clear that all that it > calls for does not yet seem to be provided by > your proposed changes. >=20 > Yet you reply (only) to my comment that you can > ignore my feedback about `*-allow-shift-selection', > to say that you have therefore closed _this_ bug. >=20 > I'm amazed - unless you did this accidentally, > confusing the two bugs and meaning to close the > other bug instead. >=20 > If you really intended to close this bug, please > say how "all [my] remarks were taken into > consideration" and how this enhancement request > has been entirely fulfilled. That's not clear > to me. >=20 > From my point of view, it seems like you've made > changes to fix other bugs that incidentally make > progress toward also realizing the enhancement > requested by this bug. That's all good. >=20 > But I don't see that this enhancement has been > realized. I addressed this in specific ways, > none of which you've responded to in this > closure message. Apologies, as I seem to have misunderstood. I thought that you were just saying that what you had come up with last time is what you installed. Regarding that, this is what I thought was unfinished: >> No, this is not the case. This is very difficult >> to implement, and not worth the effort because this feature >> is already available by customizing lazy-highlight-buffer. > > I see. That disappoints me. We have lazy > highlighting but we can't use it lazily, except for > the original design of being limited to a windowful? > > Can't we "just" let scrolling move the "window limits" > as you scroll? (Yes, I'm making this up, without > looking at the code.) > > This highlight-as-you-go should really be considered > part of this enhancement request, IMO. And I mentioned > it as such. But if you don't want to tackle that part > initially, or if indeed it ends up being too complex in > the end, then so be it, for now. I thought what you installed still included that telling users that to ensure they get lazy highlighting everywhere they scroll they may need to customize `lazy-highlight-buffer. As you didn't say anything different I assumed that the "very difficult to implement, and not worth the effort" was what was reflected in what you installed. I've now tried what you ended up installing, and I see that that's not the case (and that you removed the advice that you might need to set `lazy-highlight-buffer' to t to see highlighting when scrolling). What you installed does indeed seem to implement this enhancement. Thank you for that, and sorry for not understanding and reacting negatively.