From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Jim Porter Newsgroups: gmane.emacs.bugs Subject: bug#61954: 30.0.50; [PATCH] Simplify structured commands in Eshell Date: Sun, 5 Mar 2023 18:11:44 -0800 Message-ID: <4b2704ab-d615-f6aa-90df-990444849ef0@gmail.com> References: <0a0527e8-b005-6f1a-016a-1cb0694ce639@gmail.com> <87y1oar86t.fsf@melete.silentflame.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34499"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 61954@debbugs.gnu.org To: Sean Whitton Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Mar 06 03:12:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ0Kg-0008ro-FW for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 06 Mar 2023 03:12:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pZ0Ka-0002mA-2l; Sun, 05 Mar 2023 21:12:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pZ0KY-0002lS-E2 for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 21:12:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pZ0KX-0005rr-Vz for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 21:12:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pZ0KX-0002Y0-Nf for bug-gnu-emacs@gnu.org; Sun, 05 Mar 2023 21:12:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Jim Porter Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 06 Mar 2023 02:12:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61954 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 61954-submit@debbugs.gnu.org id=B61954.16780687139777 (code B ref 61954); Mon, 06 Mar 2023 02:12:01 +0000 Original-Received: (at 61954) by debbugs.gnu.org; 6 Mar 2023 02:11:53 +0000 Original-Received: from localhost ([127.0.0.1]:41021 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZ0KP-0002Xc-09 for submit@debbugs.gnu.org; Sun, 05 Mar 2023 21:11:53 -0500 Original-Received: from mail-pg1-f179.google.com ([209.85.215.179]:38484) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pZ0KN-0002XQ-7I for 61954@debbugs.gnu.org; Sun, 05 Mar 2023 21:11:51 -0500 Original-Received: by mail-pg1-f179.google.com with SMTP id y19so4633180pgk.5 for <61954@debbugs.gnu.org>; Sun, 05 Mar 2023 18:11:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678068705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=JhCScOWswXyMiFnAEo9XVxq0lfXCH2C7vZ2D2sSqoHo=; b=jhB+LXL+5YY3vz/OCx+FvMHh6a2JJgrLNdQoFoNK4mwH4vqobahB0w4Ywlvnj7SsGl bf3fQc+YrWW5sO+I37CPysCiFz9lunlS5rcyBQlWIFTnE/4ynmg8lJSxQGl8gJ1C+Yhl ZAUMHyh4guPCp3M93pvRuQznuHg6Azk8sy867RKFPkD5RwGAziVrf5CgSNfgWQT2qQ3d Ru8Y+gqKO6hz+PL+pNpmvGhW6qC1IrnUudIyTrVO2Vf1vApL0vJJhXlWSXswl1ImV02u cKbYuFMO9Ohe1GJdOoEeNSoDSDwL7Iqy0c1GEm4tIy/SIIptIKrT+oAVLTLOUQXzPWjl gqsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678068705; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JhCScOWswXyMiFnAEo9XVxq0lfXCH2C7vZ2D2sSqoHo=; b=TBfm5r9uI1H+xxBxa6jIhXW+vV2/2KYWRGF/jaxmence3eBPIF4HWwW8JzSACcxpsw ABr/RSYkmgGoAunhoI1yDX7LNV3xEQ/zV8BTLWaFd1mPPNXXkzQF33Tr3ymw/IKpDYf0 mcQ11rlNn4GIkrf2WNkTbY+MkRe9sUfwOwnqOK4Jtopbt95CmxpJFwil6GB9H+7Vk+P8 NnTBqsRHNoMZP4TbH00ksx/6oTsUbqpPVWojwDmwZyq9GCeBimQ20w6XtAbnBq24rb0x HiVNs3RVUy4QYKk99pOATmZHZX1l5+f3oW+8FMw824UOloaRamnAbK7jThJwp9BgdFpp oziA== X-Gm-Message-State: AO0yUKWM3x0sfe3Qn13bdQwHFdpWliz2sWGwuKnIKmGDd8AO0jdl6nrg xN5ABkTcgO5sn7VBvG5/3sc= X-Google-Smtp-Source: AK7set+sJrlftgHUL+gOeVM5+5R7HhKBPI7PMV0xzZT2GmW7yoab8V+fTy0mqmLwL8U0ZvxJeXFjdA== X-Received: by 2002:aa7:8704:0:b0:594:1f1c:3d3a with SMTP id b4-20020aa78704000000b005941f1c3d3amr12454534pfo.15.1678068705036; Sun, 05 Mar 2023 18:11:45 -0800 (PST) Original-Received: from [192.168.1.2] (cpe-76-168-148-233.socal.res.rr.com. [76.168.148.233]) by smtp.googlemail.com with ESMTPSA id n4-20020a62e504000000b005a79596c795sm5098387pff.29.2023.03.05.18.11.44 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 05 Mar 2023 18:11:44 -0800 (PST) Content-Language: en-US In-Reply-To: <87y1oar86t.fsf@melete.silentflame.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:257367 Archived-At: On 3/5/2023 5:15 PM, Sean Whitton wrote: > I think you have typo'd the bug number? Sorry, bug#57635. > I would like to read about what the advantages of moving to CPS in > particular will be. My understanding was that CPS is only rarely a good > idea. Well, that's what 'eshell-do-eval' is already; it's just incomplete (doesn't understand all of Elisp) and has a number of bugs. Migrating to generator.el's CPS machinery would mean we get the benefits of a more-complete implementation, with (hopefully) fewer bugs. Whether CPS is a good idea in general is above my pay grade, but short of some major improvements to threads in Emacs, I don't see an alternative. Eshell needs *some* mechanism for deferring execution of its command forms. (As I recall, threads have issues around prompting the user, which is why Tramp doesn't yet use threads, and Eshell would have the same issues. Not only that, but if Eshell used threads, it would cause problems when Eshell code calls Tramp code.)