From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Drew Adams Newsgroups: gmane.emacs.bugs Subject: bug#31615: 27.0; doc of `uncomment-region(-default)' Date: Sat, 2 Jun 2018 13:47:38 +0000 (UTC) Message-ID: <4afe26ca-00d6-4f16-b5e2-6a7444ddcd13@default> References: <> <<83lgbxeac4.fsf@gnu.org>> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1527947171 23521 195.159.176.226 (2 Jun 2018 13:46:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 2 Jun 2018 13:46:11 +0000 (UTC) Cc: 31615@debbugs.gnu.org To: Eli Zaretskii , Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jun 02 15:46:07 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP6r8-000601-5w for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 15:46:06 +0200 Original-Received: from localhost ([::1]:59889 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP6tF-0004rF-9k for geb-bug-gnu-emacs@m.gmane.org; Sat, 02 Jun 2018 09:48:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:37851) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fP6t4-0004pc-Uz for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 09:48:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fP6t0-00089W-2r for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 09:48:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:50602) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fP6sz-00089H-V8 for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 09:48:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fP6sz-0005R9-PN for bug-gnu-emacs@gnu.org; Sat, 02 Jun 2018 09:48:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Drew Adams Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Jun 2018 13:48:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 31615 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 31615-submit@debbugs.gnu.org id=B31615.152794726920878 (code B ref 31615); Sat, 02 Jun 2018 13:48:01 +0000 Original-Received: (at 31615) by debbugs.gnu.org; 2 Jun 2018 13:47:49 +0000 Original-Received: from localhost ([127.0.0.1]:58499 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP6sm-0005Qg-Nu for submit@debbugs.gnu.org; Sat, 02 Jun 2018 09:47:48 -0400 Original-Received: from userp2130.oracle.com ([156.151.31.86]:39622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fP6sl-0005QO-1T for 31615@debbugs.gnu.org; Sat, 02 Jun 2018 09:47:47 -0400 Original-Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.22/8.16.0.22) with SMTP id w52DlfOb057379; Sat, 2 Jun 2018 13:47:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : cc : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2017-10-26; bh=JZF/1ALP4k9haSSG5XxtVrMEZBE1SnKfhHYVQ3BUh3w=; b=lq64TTl6Ebe9obykx+02pBGmRSMQTIWrxP1vScAZ7/IjY9xCojjKWRhL79o7+XfBwMvJ pLg7afg28VNFIJ7Sx7apvZl3Wjgegxd5nnfBW4bUweTOHEtSMLW9UXeUxzSJkNwaE9ll zfV9sui7jpSoEo7ttiFQMujh1dMehRp613T/7XeVe5r229rm2sRIWlXVUBxX04sC0gLY XeSlVWHdisC6kgQVtHzhwQ8bh+7+i3pLBLU0puyl57mzhXjseUF1UWWyWa3GC6UCVLmT tNqJaoSA6DuGkPy9g/wvxaK1FvNbIF6DqA4op+iDPGnHlKkiPfjsy7Wcl5tffk8AxJha Ew== Original-Received: from aserv0021.oracle.com (aserv0021.oracle.com [141.146.126.233]) by userp2130.oracle.com with ESMTP id 2jbjpa8krh-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 02 Jun 2018 13:47:40 +0000 Original-Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserv0021.oracle.com (8.14.4/8.14.4) with ESMTP id w52Dleli027971 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 2 Jun 2018 13:47:40 GMT Original-Received: from abhmp0006.oracle.com (abhmp0006.oracle.com [141.146.116.12]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id w52DldJV019808; Sat, 2 Jun 2018 13:47:39 GMT In-Reply-To: <<83lgbxeac4.fsf@gnu.org>> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.4690.0 (x86)] X-Proofpoint-Virus-Version: vendor=nai engine=5900 definitions=8911 signatures=668702 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 malwarescore=0 phishscore=0 bulkscore=0 spamscore=0 mlxscore=0 mlxlogscore=755 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1805220000 definitions=main-1806020163 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:146863 Archived-At: > Done. Thx. > > 2. The doc strings should be much more specific about the behavior, in > > particular wrt ARG. Apparently the functions do nothing at all if ARG > > is larger than the first sequence of comment chars in the region. > > > > E.g. for a comment such as this one: > > ;; foo bar > > (uncomment-region (line-beginning-position) (line-end-position) 3) > > does nothing. That's not obvious from the doc. >=20 > I'm not sure this was the intent of the code. I'd expect it to remove > the maximum number of comment delimiters it can, not just punt > silently. I too think that should be the behavior, but who knows what the intention was. If the behavior gets fixed to do that then great. In any case (fixed behavior, intended but not yet fixed behavior, or current behavior), I think the behavior should be documented. > It means "comment delimiters"; fixed. Thx. > > 4. Enhancement request: Provide a way to remove ALL comment chars and > > all whitespace between them, up to the first non-comment char. >=20 > Not done. Right. Shall we leave this bug open for that enhancement request, or do you want a new report for just that?