From: Drew Adams <drew.adams@oracle.com>
To: Eli Zaretskii <eliz@gnu.org>, Drew Adams <drew.adams@oracle.com>
Cc: 31615@debbugs.gnu.org
Subject: bug#31615: 27.0; doc of `uncomment-region(-default)'
Date: Sat, 2 Jun 2018 13:47:38 +0000 (UTC) [thread overview]
Message-ID: <4afe26ca-00d6-4f16-b5e2-6a7444ddcd13@default> (raw)
In-Reply-To: <<83lgbxeac4.fsf@gnu.org>>
> Done.
Thx.
> > 2. The doc strings should be much more specific about the behavior, in
> > particular wrt ARG. Apparently the functions do nothing at all if ARG
> > is larger than the first sequence of comment chars in the region.
> >
> > E.g. for a comment such as this one:
> > ;; foo bar
> > (uncomment-region (line-beginning-position) (line-end-position) 3)
> > does nothing. That's not obvious from the doc.
>
> I'm not sure this was the intent of the code. I'd expect it to remove
> the maximum number of comment delimiters it can, not just punt
> silently.
I too think that should be the behavior, but who knows what
the intention was. If the behavior gets fixed to do that
then great. In any case (fixed behavior, intended but not
yet fixed behavior, or current behavior), I think the
behavior should be documented.
> It means "comment delimiters"; fixed.
Thx.
> > 4. Enhancement request: Provide a way to remove ALL comment chars and
> > all whitespace between them, up to the first non-comment char.
>
> Not done.
Right. Shall we leave this bug open for that enhancement
request, or do you want a new report for just that?
next parent reply other threads:[~2018-06-02 13:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <<f7e49ba0-f2bd-4da0-84bd-f6cda8167a0e@default>
[not found] ` <<83lgbxeac4.fsf@gnu.org>
2018-06-02 13:47 ` Drew Adams [this message]
2018-06-02 14:14 ` bug#31615: 27.0; doc of `uncomment-region(-default)' Eli Zaretskii
2018-05-28 4:20 Drew Adams
2018-06-02 10:44 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4afe26ca-00d6-4f16-b5e2-6a7444ddcd13@default \
--to=drew.adams@oracle.com \
--cc=31615@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).