From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Daniel Mendler Newsgroups: gmane.emacs.bugs Subject: bug#47992: [External] : bug#47992: 27; 28; Phase out use of `equal` in `add-hook`, `remove-hook` Date: Sat, 24 Apr 2021 23:34:52 +0200 Message-ID: <4a527e2e-710f-9c8d-8f89-00a97f93175d@daniel-mendler.de> References: <95dee1b3-10c4-24fb-e483-ec3f36bdf5f0@daniel-mendler.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28141"; mail-complaints-to="usenet@ciao.gmane.io" Cc: "monnier@iro.umontreal.ca" , "jakanakaevangeli@chiru.no" To: Drew Adams , "47992@debbugs.gnu.org" <47992@debbugs.gnu.org> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Apr 24 23:36:11 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1laPwh-00078J-3R for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Apr 2021 23:36:11 +0200 Original-Received: from localhost ([::1]:52322 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1laPwf-00007D-H5 for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Apr 2021 17:36:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:47516) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1laPwY-00006B-GK for bug-gnu-emacs@gnu.org; Sat, 24 Apr 2021 17:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:58304) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1laPwY-0006PW-3o for bug-gnu-emacs@gnu.org; Sat, 24 Apr 2021 17:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1laPwY-0000E5-12 for bug-gnu-emacs@gnu.org; Sat, 24 Apr 2021 17:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Daniel Mendler Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Apr 2021 21:36:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 47992 X-GNU-PR-Package: emacs Original-Received: via spool by 47992-submit@debbugs.gnu.org id=B47992.1619300107800 (code B ref 47992); Sat, 24 Apr 2021 21:36:01 +0000 Original-Received: (at 47992) by debbugs.gnu.org; 24 Apr 2021 21:35:07 +0000 Original-Received: from localhost ([127.0.0.1]:41617 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laPvf-0000Cq-4i for submit@debbugs.gnu.org; Sat, 24 Apr 2021 17:35:07 -0400 Original-Received: from server.qxqx.de ([178.63.65.180]:49479 helo=mail.qxqx.de) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1laPva-0000CB-68 for 47992@debbugs.gnu.org; Sat, 24 Apr 2021 17:35:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=qxqx.de; s=mail1392553390; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=f9PCUEgwKrHd2wZ9BZXV3OGrC+EU+BlrIMiUdceo0E4=; b=AX1MJnpwpZw988Ou9wb5yEYFHi NI0+r8WwxoYqli21jm/lZTH3bltp2yvEyr/NYiAB7Ye8zdhoVmR3XYnUcdKwKe5XDYA2hpOxTJMSC CZYRPJ5Qa29VwWD7vLbKarcEofipmniDG71h6Ug5N9sO4oSmSI5w9U+kILxcAn2S8yxE=; In-Reply-To: Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:204825 Archived-At: On 4/24/21 11:20 PM, Drew Adams wrote: > Shouldn't your argument be that closure equality should > _always_ be tested (testable) using just `eq'? Is this > really about `add|remove-hook'? Why would they be > special in this regard? This could be discussed. But a change in equality would be much more impactful. There are reasons why one would want to allow structural equality testing for closures. I don't see a problem with it if I opt-in explicitly by using `equal`. It is still the wrong equality for `add/remove-hook` which should be robust. And currently it is not.