From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#11810: 24.1.50; `vc-diff' shrinks pre-existing window Date: Fri, 06 Jul 2012 08:36:30 +0200 Message-ID: <4FF6876E.2050904@gmx.at> References: <4FECAF0F.1080307@yandex.ru> <4FED556A.4060702@gmx.at> <4FEE2EA5.5060905@yandex.ru> <4FEEC259.7040308@gmx.at> <4FEF8935.9010508@yandex.ru> <4FF012FE.1010502@gmx.at> <4FF05DC0.4080609@yandex.ru> <4FF146F4.1080103@gmx.at> <4FF1A30F.4090806@yandex.ru> <4FF1CD2C.5000704@gmx.at> <4FF206F5.4030101@yandex.ru> <4FF29BE7.2030006@gmx.at> <4FF2EA0D.9030006@yandex.ru> <4FF3207B.1050609@gmx.at> <4FF3404E.6000207@yandex.ru> <4FF40A6C.2050601@gmx.at> <4FF46B89.5040301@yandex.ru> <4FF56410.7000705@gmx.at> <4FF62109.6000608@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341556635 20571 80.91.229.3 (6 Jul 2012 06:37:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Jul 2012 06:37:15 +0000 (UTC) Cc: 11810@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jul 06 08:37:14 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sn2AC-0003NG-0Y for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2012 08:37:12 +0200 Original-Received: from localhost ([::1]:49196 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn2AA-0006Yg-L1 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Jul 2012 02:37:10 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:46056) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn2A7-0006YL-FO for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 02:37:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sn2A5-0007LS-SK for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 02:37:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41801) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sn2A5-0007LB-Nt for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 02:37:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sn2Er-0001pZ-L5 for bug-gnu-emacs@gnu.org; Fri, 06 Jul 2012 02:42:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Jul 2012 06:42:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11810-submit@debbugs.gnu.org id=B11810.13415568926971 (code B ref 11810); Fri, 06 Jul 2012 06:42:01 +0000 Original-Received: (at 11810) by debbugs.gnu.org; 6 Jul 2012 06:41:32 +0000 Original-Received: from localhost ([127.0.0.1]:51347 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sn2EO-0001oN-3Q for submit@debbugs.gnu.org; Fri, 06 Jul 2012 02:41:32 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:48049) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1Sn2EM-0001oG-3W for 11810@debbugs.gnu.org; Fri, 06 Jul 2012 02:41:31 -0400 Original-Received: (qmail invoked by alias); 06 Jul 2012 06:36:32 -0000 Original-Received: from 62-47-51-37.adsl.highway.telekom.at (EHLO [62.47.51.37]) [62.47.51.37] by mail.gmx.net (mp034) with SMTP; 06 Jul 2012 08:36:32 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX194TbkdDyp4Xb6hTqpTvFqQgPudpbz6VlrtMITLxw tEOgvGGEbc2Ynk In-Reply-To: <4FF62109.6000608@yandex.ru> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61638 Archived-At: > That should work, but IMO `even-window-heights' behavior is just too > surprising (with its conditions on window positions), so, if you don't > mind, I'll open another bug with proposal to change its default value, > presenting the above as alternative. OK >> I'm more concerned with the fact that an application might reuse the >> shrunk window via `display-buffer'. > > In this case, unless the new buffer is the same as the one already > displayed in the shrunk window, `display-buffer-record-window' will > overwrite the 'quit-restore parameter, so I don't see what the problem > scenario would be. Hadn't managed to reproduce one either. Consider users with always <= 2 windows per frame: If `display-buffer' displays some temporary buffer in the other, reused window, shrinking it to some few lines, calling `switch-to-buffer-other-window' in that situation won't be of much fun. >> > If someone wants `shrink-window-if-...' to have no effect only in >> > `vc-diff', well, that's a different goal. >> >> But that's probably what some people want. > > I don't think we've seen a request exactly like that yet, but that would > require a vc-prefixed variable. When we get such a request you'll take care of it ;-) > window.el (quit-window): Always restore window height when it's saved in > quit-restore parameter. Installed as revision 108897. martin