From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#11810: 24.1.50; `vc-diff' shrinks pre-existing window Date: Sun, 01 Jul 2012 11:06:06 +0200 Message-ID: <4FF012FE.1010502@gmx.at> References: <4FECAF0F.1080307@yandex.ru> <4FED556A.4060702@gmx.at> <4FEE2EA5.5060905@yandex.ru> <4FEEC259.7040308@gmx.at> <4FEF8935.9010508@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1341133602 2994 80.91.229.3 (1 Jul 2012 09:06:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 1 Jul 2012 09:06:42 +0000 (UTC) Cc: Juanma Barranquero , Andreas Schwab , 11810@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jul 01 11:06:41 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SlG75-0007dY-CV for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2012 11:06:39 +0200 Original-Received: from localhost ([::1]:36651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlG74-0003yp-6i for geb-bug-gnu-emacs@m.gmane.org; Sun, 01 Jul 2012 05:06:38 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlG71-0003yW-IT for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2012 05:06:36 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SlG6z-0000Al-Rx for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2012 05:06:35 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58504) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SlG6z-0000AZ-OX for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2012 05:06:33 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SlGBK-0001xb-2Q for bug-gnu-emacs@gnu.org; Sun, 01 Jul 2012 05:11:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Jul 2012 09:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11810 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11810-submit@debbugs.gnu.org id=B11810.13411338517518 (code B ref 11810); Sun, 01 Jul 2012 09:11:02 +0000 Original-Received: (at 11810) by debbugs.gnu.org; 1 Jul 2012 09:10:51 +0000 Original-Received: from localhost ([127.0.0.1]:39817 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SlGB8-0001xC-9N for submit@debbugs.gnu.org; Sun, 01 Jul 2012 05:10:51 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:42555) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SlGB4-0001x3-Tf for 11810@debbugs.gnu.org; Sun, 01 Jul 2012 05:10:48 -0400 Original-Received: (qmail invoked by alias); 01 Jul 2012 09:06:16 -0000 Original-Received: from 62-47-56-215.adsl.highway.telekom.at (EHLO [62.47.56.215]) [62.47.56.215] by mail.gmx.net (mp028) with SMTP; 01 Jul 2012 11:06:16 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+jWE9zh3yjxADmUoPpRsOtpG0eGSExAThRUbayKF wof5r+dIZxfNTu In-Reply-To: <4FEF8935.9010508@yandex.ru> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61454 Archived-At: > How is it obsolete? As far as I can see, neither of the two possible > values of `window-combination-resize' says "don't resize my existing > windows until specifically asked". You would customize `window-combination-resize' only with `even-window-heights' implicitly nil. >> `temp-buffer-resize-mode' adds `resize-temp-buffer-window' to >> `temp-buffer-window-show-hook' so it resizes the window even when it's >> reused. Or do I miss something? > > Actually yes, I haven't tested it properly the last time. > It can shrink the window to make it fit the buffer, but it restores the > window's size when it's done, which is the important thing. It explicitly checks whether `temp-buffer-resize-mode' is on when the buffer shall be removed. >> I don't recall the details but we always had a chicken-and-egg problem >> here: When you fill a buffer before displaying it you can't make its >> line breaks suit the window used for it. When you display it first, you >> can't make the window suit the line breaks of the buffer. And the >> number of line breaks determines the height of the region to display. > > Do you mean auto-filling, as in, "inserting hard newlines"? I don't > think diff-mode does that. It does pop a window immediately, but > probably just because it would be weird to see a window pop up only > after the diff command finishes (if that happens after some time has > passed). Must have been a different problem indeed, probably in the context of man or woman, IIRC. >> Couldn't >> we use the `quit-restore' window parameter to restore the original size >> of the window? > > We probably could, if solving only this particular case is okay. As far > as VC package goes, we'd need to do that in `vc-diff-internal' and in > all (?) callers of `vc-log-internal-common'. We could simply remove the `temp-buffer-resize-mode' check in `quit-window'. I hardly understand what implications this might have. martin