From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#11757: Acknowledgement (24.1.50; vc-git calls `process-file' too many times) Date: Fri, 29 Jun 2012 21:03:20 +0400 Message-ID: <4FEDDFD8.1010407@yandex.ru> References: <4FE2832A.1030308@yandex.ru> <4FE994E8.9020605@yandex.ru> <87zk7qs21q.fsf@gmx.de> <4FEBAAAA.3030102@yandex.ru> <87d34igrie.fsf@gmx.de> <4FEDD2A0.3010300@yandex.ru> <878vf66pgw.fsf@gmx.de> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1340989437 24999 80.91.229.3 (29 Jun 2012 17:03:57 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 29 Jun 2012 17:03:57 +0000 (UTC) Cc: 11757@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 29 19:03:56 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Skebo-0002to-TB for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jun 2012 19:03:53 +0200 Original-Received: from localhost ([::1]:40909 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Skebo-0006B1-TO for geb-bug-gnu-emacs@m.gmane.org; Fri, 29 Jun 2012 13:03:52 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51113) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Skebl-0006A8-6v for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2012 13:03:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Skebg-0004P7-7w for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2012 13:03:48 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56187) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Skebf-0004Oy-UN for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2012 13:03:44 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Skefq-0001Hr-54 for bug-gnu-emacs@gnu.org; Fri, 29 Jun 2012 13:08:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 29 Jun 2012 17:08:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11757 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11757-submit@debbugs.gnu.org id=B11757.13409896624919 (code B ref 11757); Fri, 29 Jun 2012 17:08:02 +0000 Original-Received: (at 11757) by debbugs.gnu.org; 29 Jun 2012 17:07:42 +0000 Original-Received: from localhost ([127.0.0.1]:37500 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkefW-0001HH-Ev for submit@debbugs.gnu.org; Fri, 29 Jun 2012 13:07:42 -0400 Original-Received: from forward17.mail.yandex.net ([95.108.253.142]:37194) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SkefT-0001H3-08 for 11757@debbugs.gnu.org; Fri, 29 Jun 2012 13:07:41 -0400 Original-Received: from smtp19.mail.yandex.net (smtp19.mail.yandex.net [95.108.252.19]) by forward17.mail.yandex.net (Yandex) with ESMTP id 8A5AD10600F8; Fri, 29 Jun 2012 21:03:18 +0400 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1340989398; bh=aU3NM1/z/WUMlFQjDGHy6+EiD8wjxu7169fFKuwcHt0=; h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References: In-Reply-To:Content-Type:Content-Transfer-Encoding; b=mNV4+WtMT/+zzn1WqsPhEBE00Wn2TR8DqMbawQYeMpUFhNU8Rm+yDTw5RKpFlhXtg tAZ2jH/L5y0fMTnYYDKPNZIwFaMBF/7YkCXiNEJ2TD4pamq6lYsjSjsumC4MzNt/s7 OFuQKgJ+Hg8IgZ2XGAAonZwwmQ4FVw02nqgKhvlw= Original-Received: from smtp19.mail.yandex.net (localhost [127.0.0.1]) by smtp19.mail.yandex.net (Yandex) with ESMTP id 64199BE017F; Fri, 29 Jun 2012 21:03:18 +0400 (MSK) Original-Received: from 98-87.nwlink.spb.ru (98-87.nwlink.spb.ru [178.252.98.87]) by smtp19.mail.yandex.net (nwsmtp/Yandex) with ESMTP id 3HOqYIl0-3IOSC384; Fri, 29 Jun 2012 21:03:18 +0400 X-Yandex-Rcpt-Suid: michael.albinus@gmx.de X-Yandex-Rcpt-Suid: 11757@debbugs.gnu.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail; t=1340989398; bh=aU3NM1/z/WUMlFQjDGHy6+EiD8wjxu7169fFKuwcHt0=; h=Message-ID:Date:From:User-Agent:MIME-Version:To:CC:Subject: References:In-Reply-To:Content-Type:Content-Transfer-Encoding; b=R+CWIXQCagBaKgcD9Gppd5mAifsD/lXOk/25diPbU1w9nv+V85O7nUSOyza5PuoHf /mu2yangTYvm5gpXZRJuBAxAyC6NYia/RdOt5XXK/MtEoX+Hm4fA0A4moR73KILSOW QyxflmQrXTgBlZJ4/VHf/LZzCOGadNtjwc4Uf5mg= User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 In-Reply-To: <878vf66pgw.fsf@gmx.de> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:61415 Archived-At: On 29.06.2012 20:40, Michael Albinus wrote: >>> A stale cache is bad, of course. We must carefully check, where a cached >>> value has to be invalidated. But why should vc-working-revision being >>> invalidated after saving? It is still the same, I believe. Switching to >>> another branch shall be observed by Emacs, 'cause there is another >>> version of the file on the disk, and Emacs warns you before editing. >> >> This won't happen in following cases: >> 1) We switch to revision when the opened file is the same. >> 2) It doesn't exist there. >> 3) We just delete it from disk from outside of Emacs. >> So the file isn't changed, and you see no warning or update, even >> after you write it to disk from Emacs again. > > I see. Maybe we find a hook, where we could invalidate the vc cache when > a file is written which does not exist on the disk? (vc-before-save) might be the place to do that. >> And the latter two cases (the last one - with a small modification) >> are the only situations I can think of when an open buffer in which >> (vc-git-registered) returned t some time ago (so it has vc-backend >> property set to Git) now should return nil. >> But the properties won't be reset, so the cached value will be outdated. >> >> Can you describe a scenario in which 'git-registered cached value will >> be invalidated, and the function will then return nil? > > When the file is removed from git outside Emacs. In this case, > git-registered must be nil. I meant, would that happen with your patch? If vc-before-save would invalidate the cache, that should be ok. >> P.S. I can't find a way to apply context diff with my current setup, >> so if it's not too hard, please send a unified one next time. > > I try to remember. The Emacs maintainers prefer context diffs, that's > why ediff-custom-diff-options is set to "-c" by default. How important is that, I wonder? It's what CONTRIBUTE says, but I've seen many of the diffs posted in unified format, and no one ever asked me to convert a patch specifically into context format.