From: "Jan Djärv" <jan.h.d@swipnet.se>
To: David Caldwell <david@porkrind.org>
Cc: 18474-done@debbugs.gnu.org
Subject: bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk
Date: Sun, 14 Sep 2014 10:24:43 +0200 [thread overview]
Message-ID: <4FE6A48B-E189-4048-A4CB-C1910B3C389C@swipnet.se> (raw)
In-Reply-To: <54152DBD.6060400@porkrind.org>
Hello.
14 sep 2014 kl. 07:55 skrev David Caldwell <david@porkrind.org>:
>
> While building on Mac OS X, this code in src/callproc.c (line 1582ish):
>
> #ifdef HAVE_NS
> if (data_dir == 0)
> data_dir == ns_etc_directory () != 0;
> #endif
>
> gives a warning:
>
> cc -c -Demacs -I. -I. -I../lib -I../lib -MMD -MF
> deps/callproc.d -MP -Wno-switch
> -Wno-tautological-constant-out-of-range-compare -Wno-pointer-sign -g3
> -O2 callproc.c
>
> callproc.c:1582:14: warning: comparison between pointer and integer
> ('int' and 'const char *')
> data_dir == ns_etc_directory () != 0;
> ~~~~~~~~ ^ ~~~~~~~~~~~~~~~~~~~
> callproc.c:1582:37: warning: inequality comparison result unused
> [-Wunused-comparison]
> data_dir == ns_etc_directory () != 0;
> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~
>
> 2 warnings generated.
>
> Maybe s/==/=/ ?
>
> Looks like it was added in bzr r117829 (the huge alloca() patch).
An obvious typo, fixed now. Thanks.
Jan D.
prev parent reply other threads:[~2014-09-14 8:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-14 5:55 bug#18474: trunk; Warning in callproc.c while building for Mac OS X on trunk David Caldwell
2014-09-14 8:24 ` Jan Djärv [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE6A48B-E189-4048-A4CB-C1910B3C389C@swipnet.se \
--to=jan.h.d@swipnet.se \
--cc=18474-done@debbugs.gnu.org \
--cc=david@porkrind.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).