unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#11725: 24.1; confirm-nonexistent-file-or-buffer with after-completion value
@ 2012-06-16 17:14 Szunti
  2012-06-23  4:50 ` Stefan Monnier
  0 siblings, 1 reply; 2+ messages in thread
From: Szunti @ 2012-06-16 17:14 UTC (permalink / raw)
  To: 11725

Using the default value of "after-completion" of the variable
"confirm-nonexistent-file-or-buffer" never asks for confirmation.

I made a git bisect, the first bad commit is:

     commit 064b509639208159ca7c619bccf319aef7950146
     Author: Stefan Monnier <monnier@iro.umontreal.ca>
     Date: Mon Mar 12 00:10:59 2012 -0400

         * lisp/minibuffer.el (minibuffer-complete): Don't get confused 
when the
         function is run twice via different commands.
         (complete-with-action): Fix docstring.

Steps to reproduce after bad commit:

1) made two files in bash:
$ cd /tmp
$ touch almafa almacsutka

2) open emacs
C-x C-f /tmp/al[TAB][RET]

[TAB] completes to /tmp/alma, then after pressing [RET], a new file
called alma is open, instead of asking for confirmation.






^ permalink raw reply	[flat|nested] 2+ messages in thread

* bug#11725: 24.1; confirm-nonexistent-file-or-buffer with after-completion value
  2012-06-16 17:14 bug#11725: 24.1; confirm-nonexistent-file-or-buffer with after-completion value Szunti
@ 2012-06-23  4:50 ` Stefan Monnier
  0 siblings, 0 replies; 2+ messages in thread
From: Stefan Monnier @ 2012-06-23  4:50 UTC (permalink / raw)
  To: Szunti; +Cc: 11725-done

Version: 24.2

> 1) made two files in bash:
> $ cd /tmp
> $ touch almafa almacsutka
> 2) open emacs
> C-x C-f /tmp/al[TAB][RET]
> [TAB] completes to /tmp/alma, then after pressing [RET], a new file
> called alma is open, instead of asking for confirmation.

Thanks, I've installed the patch below on the emacs-24 branch, which
should fix the problem.


        Stefan


--- lisp/minibuffer.el	2012-04-07 08:12:04 +0000
+++ lisp/minibuffer.el	2012-06-23 04:47:36 +0000
@@ -892,7 +892,8 @@
         (completion--cache-all-sorted-completions (cdr all)))))))
 
 (defvar minibuffer-confirm-exit-commands
-  '(minibuffer-complete minibuffer-complete-word PC-complete PC-complete-word)
+  '(completion-at-point minibuffer-complete
+    minibuffer-complete-word PC-complete PC-complete-word)
   "A list of commands which cause an immediately following
 `minibuffer-complete-and-exit' to ask for extra confirmation.")
 






^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-06-23  4:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-16 17:14 bug#11725: 24.1; confirm-nonexistent-file-or-buffer with after-completion value Szunti
2012-06-23  4:50 ` Stefan Monnier

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).