From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#11604: USE_LISP_UNION_TYPE + USE_LSB_TAG cleanup. Date: Sat, 02 Jun 2012 23:50:07 -0700 Organization: UCLA Computer Science Department Message-ID: <4FCB091F.4050602@cs.ucla.edu> References: <4FC9522B.7050302@cs.ucla.edu> <83k3zqcgqg.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1338706285 17542 80.91.229.3 (3 Jun 2012 06:51:25 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 3 Jun 2012 06:51:25 +0000 (UTC) Cc: 11604@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Jun 03 08:51:24 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Sb4el-0006Xo-JE for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 08:51:19 +0200 Original-Received: from localhost ([::1]:40330 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sb4el-0006GA-Ed for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 Jun 2012 02:51:19 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44473) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sb4ei-0006G5-7N for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 02:51:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Sb4eg-0001ID-EC for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 02:51:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:45660) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Sb4eg-0001HS-As for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 02:51:14 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Sb4gQ-0003vW-MW for bug-gnu-emacs@gnu.org; Sun, 03 Jun 2012 02:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 Jun 2012 06:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11604 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11604-submit@debbugs.gnu.org id=B11604.133870632615032 (code B ref 11604); Sun, 03 Jun 2012 06:53:02 +0000 Original-Received: (at 11604) by debbugs.gnu.org; 3 Jun 2012 06:52:06 +0000 Original-Received: from localhost ([127.0.0.1]:55206 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb4fW-0003uO-Be for submit@debbugs.gnu.org; Sun, 03 Jun 2012 02:52:06 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:44272) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Sb4fR-0003ts-NH for 11604@debbugs.gnu.org; Sun, 03 Jun 2012 02:52:02 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2BB2CA60002; Sat, 2 Jun 2012 23:50:06 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 7YxjUG1upU3H; Sat, 2 Jun 2012 23:50:05 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9C7CFA60001; Sat, 2 Jun 2012 23:50:05 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:12.0) Gecko/20120430 Thunderbird/12.0.1 In-Reply-To: <83k3zqcgqg.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60655 Archived-At: On 06/02/2012 12:31 AM, Eli Zaretskii wrote: > why did you change DECL_ALIGN to DCL_ALIGN? A typo. It didn't prevent compilation on my platform. Thanks for pointing it out; the revised patch will fix this. >> + (union Lisp_Object): Don't worry about WORDS_BIGENDIAN; the >> + code works fine either way, and efficiency is not a concern here. > > why isn't efficiency a concern? Because the union type is for debugging, not for production. It's used mostly to make sure that (for example) one doesn't mistakenly write "x = y" when one meant to write "x = XINT (y)". I'll reword the ChangeLog entry to make it clearer. >> + (LISP_MAKE_RVALUE, make_number) [USE_LISP_UNION_TYPE]: >> + Use an inline function on all platforms, since this is simpler and >> + 'static inline' (via gnulib) is portable now. > > I still see one instance of LISP_MAKE_RVALUE as a macro in lisp.h: The ChangeLog entry is only about the USE_LISP_UNION_TYPE case, not the case you noticed. I'll reword this for clarity. > Also, which parts of gnulib make 'static inline' portable? If it > isn't in a part that is used by the MS-Windows port, the MSVC build is > still being screwed by these changes. Mostly, it's the AC_C_INLINE stuff in m4/*. 'static inline' been used for some time in Emacs, and it works just fine with the MSVC build. I'll reword the ChangeLog entry to remove the distracting mention of gnulib. > The following changes are not mentioned in the log entry: They are mentioned here: (XSET) [USE_LISP_UNION_TYPE]: Don't overparenthesize. > What was the reason for removing this comment: Please see Bug#11617, which I just now filed. I will restore that comment in the revised patch, as it's now an independent issue.