From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#11567: 24.0.97; WTF? ROFL! (hilarious bug) Date: Mon, 28 May 2012 20:19:14 +0200 Message-ID: <4FC3C1A2.7050800@gmx.at> References: <8CBD82E7-3C0F-4E08-9127-9DAE6A1AFC9D@web.de> <4FC352DC.5040507@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080007020507050302090705" X-Trace: dough.gmane.org 1338229260 6608 80.91.229.3 (28 May 2012 18:21:00 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 28 May 2012 18:21:00 +0000 (UTC) Cc: Tobias Bading , 11567@debbugs.gnu.org To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 28 20:20:58 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SZ4Yj-0008Ro-OP for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 May 2012 20:20:49 +0200 Original-Received: from localhost ([::1]:48091 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ4Yj-0002mm-FY for geb-bug-gnu-emacs@m.gmane.org; Mon, 28 May 2012 14:20:49 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37119) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ4Yf-0002mb-Se for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 14:20:48 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SZ4Ye-0001z3-7p for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 14:20:45 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37392) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SZ4Yd-0001yh-JS for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 14:20:43 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SZ4Zt-0004QU-SR for bug-gnu-emacs@gnu.org; Mon, 28 May 2012 14:22:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 28 May 2012 18:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11567 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11567-submit@debbugs.gnu.org id=B11567.133822926316903 (code B ref 11567); Mon, 28 May 2012 18:22:01 +0000 Original-Received: (at 11567) by debbugs.gnu.org; 28 May 2012 18:21:03 +0000 Original-Received: from localhost ([127.0.0.1]:46936 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SZ4Yw-0004OY-Vf for submit@debbugs.gnu.org; Mon, 28 May 2012 14:21:03 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.23]:47725) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SZ4Yc-0004NP-4Q for 11567@debbugs.gnu.org; Mon, 28 May 2012 14:21:01 -0400 Original-Received: (qmail invoked by alias); 28 May 2012 18:19:17 -0000 Original-Received: from 62-47-57-135.adsl.highway.telekom.at (EHLO [62.47.57.135]) [62.47.57.135] by mail.gmx.net (mp071) with SMTP; 28 May 2012 20:19:17 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18yNHhfiD0y3KTW8XbivcqUhy73ouqk4yJvT4hLPP Rc8gpWj6EgSb9G In-Reply-To: X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60429 Archived-At: This is a multi-part message in MIME format. --------------080007020507050302090705 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit >> Why can't we use `window--delete' instead of `iconify-frame' here? > > Probably no reason. Then maybe we should use `quit-window' in the first place. Attached find a patch for those who would give it a try (I hardly ever see the completions buffer). martin --------------080007020507050302090705 Content-Type: text/plain; name="simple.diff" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="simple.diff" *** lisp/simple.el 2012-05-04 23:16:47 +0000 --- lisp/simple.el 2012-05-28 17:54:25 +0000 *************** *** 6212,6227 **** (unless (buffer-live-p buffer) (error "Destination buffer is dead")) ! (select-window (posn-window (event-start event))) ! (if (and (one-window-p t 'selected-frame) ! (window-dedicated-p (selected-window))) ! ;; This is a special buffer's frame ! (iconify-frame (selected-frame)) ! (or (window-dedicated-p (selected-window)) ! (bury-buffer))) ! (select-window ! (or (get-buffer-window buffer 0) ! owindow)) (with-current-buffer buffer (choose-completion-string --- 6212,6218 ---- (unless (buffer-live-p buffer) (error "Destination buffer is dead")) ! (quit-window nil (posn-window (event-start event))) (with-current-buffer buffer (choose-completion-string --------------080007020507050302090705--