From: martin rudalics <rudalics@gmx.at>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Tobias Bading <tbading@web.de>, 11567@debbugs.gnu.org
Subject: bug#11567: 24.0.97; WTF? ROFL! (hilarious bug)
Date: Mon, 28 May 2012 20:19:14 +0200 [thread overview]
Message-ID: <4FC3C1A2.7050800@gmx.at> (raw)
In-Reply-To: <jwvbol875x8.fsf-monnier+emacs@gnu.org>
[-- Attachment #1: Type: text/plain, Size: 266 bytes --]
>> Why can't we use `window--delete' instead of `iconify-frame' here?
>
> Probably no reason.
Then maybe we should use `quit-window' in the first place. Attached
find a patch for those who would give it a try (I hardly ever see the
completions buffer).
martin
[-- Attachment #2: simple.diff --]
[-- Type: text/plain, Size: 929 bytes --]
*** lisp/simple.el 2012-05-04 23:16:47 +0000
--- lisp/simple.el 2012-05-28 17:54:25 +0000
***************
*** 6212,6227 ****
(unless (buffer-live-p buffer)
(error "Destination buffer is dead"))
! (select-window (posn-window (event-start event)))
! (if (and (one-window-p t 'selected-frame)
! (window-dedicated-p (selected-window)))
! ;; This is a special buffer's frame
! (iconify-frame (selected-frame))
! (or (window-dedicated-p (selected-window))
! (bury-buffer)))
! (select-window
! (or (get-buffer-window buffer 0)
! owindow))
(with-current-buffer buffer
(choose-completion-string
--- 6212,6218 ----
(unless (buffer-live-p buffer)
(error "Destination buffer is dead"))
! (quit-window nil (posn-window (event-start event)))
(with-current-buffer buffer
(choose-completion-string
next prev parent reply other threads:[~2012-05-28 18:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-27 14:59 bug#11567: 24.0.97; WTF? ROFL! (hilarious bug) Tobias Bading
2012-05-27 22:33 ` Troels Nielsen
2012-05-28 10:26 ` martin rudalics
2012-05-28 14:14 ` Stefan Monnier
2012-05-28 18:19 ` martin rudalics [this message]
2012-05-28 22:49 ` Troels Nielsen
2012-05-29 9:42 ` martin rudalics
2012-05-29 12:23 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FC3C1A2.7050800@gmx.at \
--to=rudalics@gmx.at \
--cc=11567@debbugs.gnu.org \
--cc=monnier@iro.umontreal.ca \
--cc=tbading@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).