unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Munawar Cheema <munawar.a.cheema@gmail.com>
Cc: 11544@debbugs.gnu.org
Subject: bug#11544: Subject: 24.1.50; ediff-buffers command window does not work properly
Date: Thu, 24 May 2012 11:01:45 +0200	[thread overview]
Message-ID: <4FBDF8F9.6060908@gmx.at> (raw)
In-Reply-To: <CADwNEa6EKG3nxAxnq7oN8Azfd28SBw52Cw7d0ENePuafkUjCqQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1065 bytes --]

Please keep CCing to 11544@debbugs.gnu.org so the information you
provide does not get lost.

 > On this bug, after typing the ? first the window grows to normal size and
 > then the window's left edge stays in place

But when you type "?" on your Windows Emacs the left edge moves?  Could
you try comparing the return values of the function
`ediff-make-frame-position' on GNU/Linux and Windows respectively?

 > and the width decreases to about
 > a characters width in a fairly continuous movement.

So it looks like an animated variant of bug#11480.

 > I tried emacs 23 and
 > it does the same thing on Ubuntu precise.  I use emacs on windows and have
 > never seen this problem using ediff there if that helps.

I don't have the slightest idea what's going on so I can only suggest to
try the following: Locate the file ediff-wind.el (in the lisp/vc
subdirectory) and try to apply the patch I attached.  At least this way
we should be able to find out whether doing two separate calls of
`modify-frame-parameters' confuses your window manager.

Thanks, martin

[-- Attachment #2: ediff-wind.diff --]
[-- Type: text/plain, Size: 1401 bytes --]

*** lisp/vc/ediff-wind.el	2012-04-26 03:04:36 +0000
--- lisp/vc/ediff-wind.el	2012-05-24 08:41:17 +0000
***************
*** 1004,1010 ****
  
      (goto-char (point-min))
  
!     (modify-frame-parameters ctl-frame adjusted-parameters)
      (make-frame-visible ctl-frame)
  
      ;; This works around a bug in 19.25 and earlier.  There, if frame gets
--- 1004,1013 ----
  
      (goto-char (point-min))
  
!     (modify-frame-parameters
!      ctl-frame
!      (append adjusted-parameters
! 	     (funcall ediff-control-frame-position-function ctl-buffer fwidth fheight)))
      (make-frame-visible ctl-frame)
  
      ;; This works around a bug in 19.25 and earlier.  There, if frame gets
***************
*** 1024,1032 ****
  
      ;; Now move the frame.  We must do it separately due to an obscure bug in
      ;; XEmacs
!     (modify-frame-parameters
!      ctl-frame
!      (funcall ediff-control-frame-position-function ctl-buffer fwidth fheight))
  
      ;; synchronize so the cursor will move to control frame
      ;; per RMS suggestion
--- 1027,1035 ----
  
      ;; Now move the frame.  We must do it separately due to an obscure bug in
      ;; XEmacs
!     ;; (modify-frame-parameters
!      ;; ctl-frame
!      ;; (funcall ediff-control-frame-position-function ctl-buffer fwidth fheight))
  
      ;; synchronize so the cursor will move to control frame
      ;; per RMS suggestion


  parent reply	other threads:[~2012-05-24  9:01 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-22 20:54 bug#11544: Subject: 24.1.50; ediff-buffers command window does not work properly Munawar Cheema
2012-05-23  9:10 ` martin rudalics
     [not found]   ` <CADwNEa6EKG3nxAxnq7oN8Azfd28SBw52Cw7d0ENePuafkUjCqQ@mail.gmail.com>
2012-05-24  9:01     ` martin rudalics [this message]
2012-05-24 16:25       ` Glenn Morris
  -- strict thread matches above, loose matches on Subject: below --
2012-05-15  8:26 bug#11480: 24.1.50; ediff command frame auto-shrinks to 1 column wide Keith Rautenbach
2022-05-02  9:43 ` bug#11544: Subject: 24.1.50; ediff-buffers command window does not work properly Lars Ingebrigtsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBDF8F9.6060908@gmx.at \
    --to=rudalics@gmx.at \
    --cc=11544@debbugs.gnu.org \
    --cc=munawar.a.cheema@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).