From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#11508: 24.1.50; Off-by-one error in xg_select? Date: Sun, 20 May 2012 18:44:59 -0400 Message-ID: <4FB973EB.9060705@cornell.edu> References: <4FB64B05.6020709@cornell.edu> <3B902B7C-C59A-4933-A6AA-E23DB052704C@swipnet.se> <73ED1C31-12C1-4424-9DEC-632A1F0050D4@swipnet.se> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1337553936 8858 80.91.229.3 (20 May 2012 22:45:36 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 May 2012 22:45:36 +0000 (UTC) Cc: 11508@debbugs.gnu.org To: Andreas Schwab Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon May 21 00:45:35 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SWEsX-0007OQ-Jp for geb-bug-gnu-emacs@m.gmane.org; Mon, 21 May 2012 00:45:33 +0200 Original-Received: from localhost ([::1]:38651 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWEsX-0003Hz-4Q for geb-bug-gnu-emacs@m.gmane.org; Sun, 20 May 2012 18:45:33 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51553) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWEsT-0003Hs-IR for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 18:45:31 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SWEsR-0007bX-UN for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 18:45:29 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54445) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SWEsR-0007bR-R0 for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 18:45:27 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SWEsz-0001Po-ST for bug-gnu-emacs@gnu.org; Sun, 20 May 2012 18:46:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 20 May 2012 22:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11508 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11508-submit@debbugs.gnu.org id=B11508.13375539575430 (code B ref 11508); Sun, 20 May 2012 22:46:01 +0000 Original-Received: (at 11508) by debbugs.gnu.org; 20 May 2012 22:45:57 +0000 Original-Received: from localhost ([127.0.0.1]:35758 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SWEsv-0001PX-7F for submit@debbugs.gnu.org; Sun, 20 May 2012 18:45:57 -0400 Original-Received: from limestone4.mail.cornell.edu ([128.253.83.164]:33610) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SWEst-0001PK-8S for 11508@debbugs.gnu.org; Sun, 20 May 2012 18:45:56 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone4.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4KMj6w1000756; Sun, 20 May 2012 18:45:06 -0400 (EDT) Original-Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q4KMjCZs000900; Sun, 20 May 2012 18:45:13 -0400 (EDT) Original-Received: from [192.168.1.4] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q4KMjAK2025907 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Sun, 20 May 2012 18:45:11 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:11.0) Gecko/20120327 Thunderbird/11.0.1 In-Reply-To: X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.20.223315 X-Original-Sender: kbrown@cornell.edu - Sun May 20 18:45:12 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-MIME-Autoconverted: from 8bit to quoted-printable by limestone4.mail.cornell.edu id q4KMj6w1000756 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:60239 Archived-At: On 5/19/2012 5:52 AM, Andreas Schwab wrote: > Jan Dj=C3=A4rv writes: > >> So the question is, is it more effective to give select the exact valu= e >> (select works fine if nfds has a higher value than strictly neccessary= ), >> or always increment by one in lines 78 and 83? > > IMHO it doesn't hurt to be exact, and the patch removes an inconsistenc= y > which makes it easier to understand the code. So can I go ahead and make this change? Jan, do you still object? Ken