From: Ken Brown <kbrown@cornell.edu>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: 9754@debbugs.gnu.org, Achim Gratz <Stromeko@nexgo.de>,
Paul Eggert <eggert@cs.ucla.edu>
Subject: bug#9754: Issue with Emacs 23.4
Date: Thu, 17 May 2012 14:26:42 -0400 [thread overview]
Message-ID: <4FB542E2.7020304@cornell.edu> (raw)
In-Reply-To: <jwvehqilunv.fsf-monnier+emacs@gnu.org>
On 5/17/2012 11:02 AM, Stefan Monnier wrote:
>>> So maybe the test
>>> if (inhibit_window_system || !display_arg)
>>> in my patch should be replaced by
>>> if (!x_in_use)
>
> Maybe. As I said, I'm not familiar enough with that code to really know
> what are the consequences, I just mentioned a few potential problems
> (without even knowing whether they're real).
>
> So unless someone more knowledgeable can confirm that the patch is
> "obviously safe" I don't want to see it in the emacs-24 branch.
I understand, and I'm no longer proposing the patch for the emacs-24
branch. My question is about what should be done in the trunk. It
seems to me that it would be better to use x_in_use, and I'm wondering
if knowledgeable people agree.
Ken
next prev parent reply other threads:[~2012-05-17 18:26 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABhPDt8f1iNs0+1N6Rn-8VbRPcscvbAda9KB388AzphWj4s_QA@mail.gmail.com>
[not found] ` <4FAC34DA.7040606@cs.ucla.edu>
2012-05-15 19:08 ` bug#9754: Issue with Emacs 23.4 Ken Brown
2012-05-15 21:51 ` Paul Eggert
2012-05-15 22:28 ` Ken Brown
2012-05-16 2:23 ` Stefan Monnier
[not found] ` <1318609098.30586.7.camel@moonpix.lan>
2011-10-14 17:48 ` bug#9754: emacs -nv fails on glib 2.31 Glenn Morris
2011-10-16 5:15 ` Paul Eggert
2011-11-11 12:32 ` Olivier Blin
2011-11-11 17:16 ` Glenn Morris
2012-01-28 21:14 ` Ulrich Mueller
2012-05-16 17:39 ` bug#9754: Issue with Emacs 23.4 Achim Gratz
2012-05-17 1:19 ` Stefan Monnier
2012-05-17 11:04 ` Ken Brown
2012-05-17 12:43 ` Ken Brown
2012-05-17 12:49 ` Andreas Schwab
2012-05-17 13:20 ` Ken Brown
2012-05-17 14:01 ` Andreas Schwab
2012-05-17 15:02 ` Stefan Monnier
2012-05-17 18:26 ` Ken Brown [this message]
2012-05-18 16:33 ` Glenn Morris
2012-05-18 17:09 ` Ken Brown
2012-05-19 6:30 ` Glenn Morris
2012-05-19 12:38 ` Ken Brown
2012-05-18 18:02 ` Stefan Monnier
2012-05-18 18:38 ` Ken Brown
2012-05-18 19:12 ` Paul Eggert
2012-05-18 20:04 ` Ken Brown
2012-05-19 21:56 ` Ken Brown
2012-05-25 20:32 ` Ken Brown
2012-05-17 6:24 ` Achim Gratz
2012-05-16 6:42 ` Michael Albinus
2012-05-16 2:28 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB542E2.7020304@cornell.edu \
--to=kbrown@cornell.edu \
--cc=9754@debbugs.gnu.org \
--cc=Stromeko@nexgo.de \
--cc=eggert@cs.ucla.edu \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).