unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: 11415@debbugs.gnu.org
Subject: bug#11415: 24.1.50; Dbus hangs indefinitely during batch mode & daemon startup
Date: Mon, 14 May 2012 08:30:36 -0700	[thread overview]
Message-ID: <4FB1251C.3020604@cs.ucla.edu> (raw)
In-Reply-To: <4FA5A187.1010601@thompsonclan.org>

That patch had a minor issue with it, discovered by configuring with
"./configure --enable-gcc-warnings", in that it sometimes resulted
in a local variable that was never used.  I installed the following
further patch to work around this.  These days there's no point to
making such variables 'register' so I removed the 'register' while
I was at it.

=== modified file 'src/ChangeLog'
--- src/ChangeLog	2012-05-14 15:11:10 +0000
+++ src/ChangeLog	2012-05-14 15:22:29 +0000
@@ -1,5 +1,7 @@
 2012-05-14  Paul Eggert  <eggert@cs.ucla.edu>
 
+	* keyboard.c (kbd_buffer_get_event) [!HAVE_DBUS]: Omit unused local.
+
 	* unexaix.c: Port to more-recent AIX compilers.
 	(report_error, report_error_1, make_hdr, copy_sym)
 	(mark_x, adjust_lnnoptrs, unrelocate_symbols):

=== modified file 'src/keyboard.c'
--- src/keyboard.c	2012-05-14 07:05:03 +0000
+++ src/keyboard.c	2012-05-14 15:22:29 +0000
@@ -3786,7 +3786,6 @@
                       int *used_mouse_menu,
                       struct timeval *end_time)
 {
-  register int c;
   Lisp_Object obj;
 
 #ifdef subprocesses
@@ -3809,7 +3808,7 @@
 	 detaching from the terminal.  */
       || (IS_DAEMON && daemon_pipe[1] >= 0))
     {
-      c = getchar ();
+      int c = getchar ();
       XSETINT (obj, c);
       *kbp = current_kboard;
       return obj;






      parent reply	other threads:[~2012-05-14 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-05 21:54 bug#11415: 24.1.50; Dbus hangs indefinitely during batch mode & daemon startup Ryan C. Thompson
2012-05-06 10:59 ` Michael Albinus
2012-05-07 14:28   ` Michael Albinus
2012-05-07 15:04     ` Christopher Schmidt
2012-05-14  7:08     ` Michael Albinus
2012-05-14 15:30 ` Paul Eggert [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB1251C.3020604@cs.ucla.edu \
    --to=eggert@cs.ucla.edu \
    --cc=11415@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).