unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 11365@debbugs.gnu.org, sds@gnu.org
Subject: bug#11365: 24.1.50; quitting gdb does not restore window configuration
Date: Sat, 05 May 2012 11:42:04 +0200	[thread overview]
Message-ID: <4FA4F5EC.8080203@gmx.at> (raw)
In-Reply-To: <83mx5qsh8v.fsf@gnu.org>

 > It is IMO wrong to do what Sam wants in gdb-delete-frame-or-window.

`gdb-delete-frame-or-window' is completely unrelated to this discussion.
I was mislead by its binding to `quit' in `gdb-breakpoints-mode-map' and
the fact that it could delete a window or frame.  Sorry for bringing it
in here in the first place.

 > That's because the restoration of the window configuration should be
 > done when GDB actually exits, not when the user _tells_ GDB to exit.
 > The function which handles the exit event is gdb-reset.

Indeed.  However, this presents a problem of orthogonality.  We would
have to save the window configuration in `gud-common-init' (in gud.el)
and restore it in `gdb-reset' (in gdb-mi.el) which looks pretty ugly to
me.  So `gud-common-init' would have to be aware of whether it's called
from `gdb' to avoid a leak.  Note that every stored window configuration
uses up memory and causes overhead for maintaining markers.

martin





  reply	other threads:[~2012-05-05  9:42 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 18:40 bug#11365: 24.1.50; quitting gdb does not restore window configuration Sam Steingold
2012-04-27 19:01 ` Eli Zaretskii
2012-04-27 19:34   ` Sam Steingold
2012-04-28  6:51     ` Eli Zaretskii
2012-04-28  8:25 ` martin rudalics
2012-04-30 22:14   ` Sam Steingold
2012-05-01  8:09     ` martin rudalics
2012-05-01 12:25       ` Sam Steingold
2012-05-02  9:39         ` martin rudalics
2012-05-02 14:16           ` Sam Steingold
2012-05-05  9:42             ` martin rudalics
2012-05-06  5:40               ` Sam Steingold
2012-05-06 10:25                 ` martin rudalics
2020-09-27 12:41         ` Lars Ingebrigtsen
2020-09-27 12:56           ` Eli Zaretskii
2020-09-27 13:00             ` Lars Ingebrigtsen
2020-09-27 13:02               ` Eli Zaretskii
2022-04-25 15:05               ` Lars Ingebrigtsen
2022-05-24 12:51                 ` Lars Ingebrigtsen
2012-05-01 15:54       ` Eli Zaretskii
2012-05-02  9:40         ` martin rudalics
2012-05-02 16:02           ` Eli Zaretskii
2012-05-05  9:42             ` martin rudalics [this message]
2012-05-05  9:49               ` Eli Zaretskii
2012-05-05 10:24                 ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FA4F5EC.8080203@gmx.at \
    --to=rudalics@gmx.at \
    --cc=11365@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=sds@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).