From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric M. Ludlam" Newsgroups: gmane.emacs.bugs Subject: bug#10781: EIEIO namespace use Date: Sat, 28 Apr 2012 18:29:44 -0400 Message-ID: <4F9C6F58.7070803@siege-engine.com> References: <87aa1wi206.fsf@engster.org> <87wr4zhmw4.fsf@engster.org> <87sjfnh8lv.fsf@engster.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1335652263 9959 80.91.229.3 (28 Apr 2012 22:31:03 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 Apr 2012 22:31:03 +0000 (UTC) Cc: 10781@debbugs.gnu.org To: David Engster Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Apr 29 00:31:02 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SOGAQ-0007Sj-36 for geb-bug-gnu-emacs@m.gmane.org; Sun, 29 Apr 2012 00:31:02 +0200 Original-Received: from localhost ([::1]:57802 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOGAP-0000iy-CM for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Apr 2012 18:31:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44839) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOGAM-0000ii-BL for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:30:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SOGAK-0002lw-Kv for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:30:57 -0400 Original-Received: from [140.186.70.43] (port=56213 helo=debbugs.gnu.org) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SOGAK-0002lL-F7 for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:30:56 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SOGBO-0002Fo-Bb for bug-gnu-emacs@gnu.org; Sat, 28 Apr 2012 18:32:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Eric M. Ludlam" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Apr 2012 22:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10781-submit@debbugs.gnu.org id=B10781.13356522888623 (code B ref 10781); Sat, 28 Apr 2012 22:32:02 +0000 Original-Received: (at 10781) by debbugs.gnu.org; 28 Apr 2012 22:31:28 +0000 Original-Received: from localhost ([127.0.0.1]:57247 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOGAo-0002Ey-Bi for submit@debbugs.gnu.org; Sat, 28 Apr 2012 18:31:28 -0400 Original-Received: from mail-qc0-f172.google.com ([209.85.216.172]:38540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SOGAT-0002E2-6Q for 10781@debbugs.gnu.org; Sat, 28 Apr 2012 18:31:24 -0400 Original-Received: by qcsq13 with SMTP id q13so919772qcs.3 for <10781@debbugs.gnu.org>; Sat, 28 Apr 2012 15:29:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=1bQIDtsCIbYtG8fJbGrEkzlblaG1yyuvhUGWW0ZYYVw=; b=aOJM4VHVOFCCclStSVNolANThNAbogCtq3bEvk99YFAZQYKJ7fRKIUZtOe8IG18k69 CHeFSDuPKoZxoR8ablcPMaMmIE9O/dqY6XVP4gcrvRp0raxS45mw/terpjAvwREF0Omx 6wQf2dEm2iuQbroL7uK1yP2NX+P8REZie9TThMnnDFdphL1yXrveb4gh8oAcqe7kVCSk yzeDYHLX0b4ZSrcZ2CyRp2XLnXo3XCLv55IuiIkCNFU2ISQYisA08xV02eGrzAQ96QW3 WpEwNULQVG181YGUoBseskwbPVig9Va08jvdCg4IlZ73af1fGuwdm9E0QirgNujdLctd rZPQ== Original-Received: by 10.224.109.65 with SMTP id i1mr13655721qap.39.1335652186479; Sat, 28 Apr 2012 15:29:46 -0700 (PDT) Original-Received: from [192.168.1.201] (pool-71-184-213-12.bstnma.fios.verizon.net. [71.184.213.12]) by mx.google.com with ESMTPS id o7sm17307264qan.15.2012.04.28.15.29.45 (version=SSLv3 cipher=OTHER); Sat, 28 Apr 2012 15:29:45 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20091222 Shredder/3.1a1pre In-Reply-To: <87sjfnh8lv.fsf@engster.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:59612 Archived-At: On 04/28/2012 05:03 PM, David Engster wrote: > Stefan Monnier writes: >>> Yes, I think 'this' should indeed become 'eieio-this'. It will also be >>> the most work, since at least in CEDET you *very* often have >> >>> (defmethod foo ((this someclass) ...) >>> ...) >> >>> so a 'this' in such a method is perfectly fine. >> >> An alternative approach is to keep the name `this' but get rid of the >> global definition. I.e. Either completely remove the (defvar this nil), >> or replace it with (defvar this). > > Eric, what would you prefer? I don't know enough about CLOS to say how > important a global 'eieio-this' actually is. Either way, I just tested > both solutions on CEDET trunk and each produced exactly this single > compile warning: > > In ede-flush-directory-hash: > files.el:230:38:Warning: reference to free variable `this' > > So actually, this appears to be a much smaller issue than I initially > thought. It seems pretty much every 'this' in CEDET is already bound in > the defmethod's argument list. I would be happy to see 'this' just completely removed. It was put in when I was mimicing C++, and some old programs of mine that have long since rotted away depended on it. I'm actually surprised there was a reference to it in CEDET still. That will be good to clean up. Eric