From: Ken Brown <kbrown@cornell.edu>
To: Andreas Schwab <schwab@linux-m68k.org>
Cc: Lars Ingebrigtsen <larsi@gnus.org>,
dan.colascione@gmail.com, 9119@debbugs.gnu.org
Subject: bug#9119: [PATCH] modernize function definitions in gmalloc.c
Date: Fri, 13 Apr 2012 18:35:54 -0400 [thread overview]
Message-ID: <4F88AA4A.1030108@cornell.edu> (raw)
In-Reply-To: <m23987mhnw.fsf@igel.home>
On 4/13/2012 5:43 PM, Andreas Schwab wrote:
> Lars Ingebrigtsen<larsi@gnus.org> writes:
>
>> Eli Zaretskii<eliz@gnu.org> writes:
>>
>>>> So would it be OK to apply this patch, then?
>>>
>>> Yes, please.
>>
>> For some reason or other, patch won't accept the, er, patch:
>>
>> patch: **** malformed patch at line 19: === modified file 'src/gmalloc.c'
>>
>> I can't really see anything wrong with the patch by eyeballing it,
>> though. Odd.
>
> The first hunk is obviously broken. It claims to add two lines but adds
> only one.
A more recent version of the patch was submitted in
http://lists.gnu.org/archive/html/emacs-devel/2011-12/msg00609.html
with improvements by Paul and me. Maybe that should be applied instead.
Ken
next prev parent reply other threads:[~2012-04-13 22:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-18 23:46 bug#9119: [PATCH] modernize function definitions in gmalloc.c Daniel Colascione
2011-07-19 17:57 ` Glenn Morris
2011-07-19 19:04 ` Andreas Schwab
2012-04-12 19:42 ` Lars Magne Ingebrigtsen
2012-04-13 8:15 ` Eli Zaretskii
2012-04-13 21:31 ` Lars Ingebrigtsen
2012-04-13 21:43 ` Andreas Schwab
2012-04-13 22:35 ` Ken Brown [this message]
2012-04-13 22:42 ` Ken Brown
2012-04-14 7:07 ` Eli Zaretskii
2012-04-14 11:15 ` Ken Brown
2012-04-14 11:21 ` Lars Ingebrigtsen
2012-04-14 13:38 ` Chong Yidong
2012-04-14 14:46 ` Eli Zaretskii
2012-04-16 7:23 ` Paul Eggert
2012-04-22 19:27 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F88AA4A.1030108@cornell.edu \
--to=kbrown@cornell.edu \
--cc=9119@debbugs.gnu.org \
--cc=dan.colascione@gmail.com \
--cc=larsi@gnus.org \
--cc=schwab@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).