From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Kim Storm Newsgroups: gmane.emacs.bugs Subject: bug#11221: cua-mode activates the mark for shifted bindings Date: Thu, 12 Apr 2012 23:28:41 +0200 Message-ID: <4F874909.3030201@cua.dk> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1334266202 28558 80.91.229.3 (12 Apr 2012 21:30:02 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 12 Apr 2012 21:30:02 +0000 (UTC) Cc: 11221@debbugs.gnu.org, Brian Tannahill To: Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Apr 12 23:30:00 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SIRaU-0004Bw-BX for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2012 23:29:54 +0200 Original-Received: from localhost ([::1]:37429 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIRaT-00039s-OI for geb-bug-gnu-emacs@m.gmane.org; Thu, 12 Apr 2012 17:29:53 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:36112) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIRaP-00039U-Ks for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 17:29:51 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SIRaO-0008AE-0P for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 17:29:49 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:58432) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SIRaN-00089b-Tc for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 17:29:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SIRba-00067W-4k for bug-gnu-emacs@gnu.org; Thu, 12 Apr 2012 17:31:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Kim Storm Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Apr 2012 21:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11221 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 11221-submit@debbugs.gnu.org id=B11221.133426620423434 (code B ref 11221); Thu, 12 Apr 2012 21:31:02 +0000 Original-Received: (at 11221) by debbugs.gnu.org; 12 Apr 2012 21:30:04 +0000 Original-Received: from localhost ([127.0.0.1]:54970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIRad-00065n-AE for submit@debbugs.gnu.org; Thu, 12 Apr 2012 17:30:04 -0400 Original-Received: from sommerhuse-i-danmark.dk ([193.201.35.153]:58937 helo=ispc3.dotserv.com) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SIRab-00064z-AE for 11221@debbugs.gnu.org; Thu, 12 Apr 2012 17:30:02 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by ispc3.dotserv.com (Postfix) with ESMTP id A8DDF8032A1BF; Thu, 12 Apr 2012 23:28:45 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at ispc3.dotserv.com Original-Received: from ispc3.dotserv.com ([127.0.0.1]) by localhost (ispc3.dotserv.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yigTXzQFfx5k; Thu, 12 Apr 2012 23:28:42 +0200 (CEST) Original-Received: from [10.1.82.9] (1405ds6-amb.0.fullrate.dk [95.166.178.253]) (Authenticated sender: storm@cua.dk) by ispc3.dotserv.com (Postfix) with ESMTPSA id 3A5EB8032A1BD; Thu, 12 Apr 2012 23:28:42 +0200 (CEST) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58950 Archived-At: On 04/12/2012 08:53 PM, Stefan Monnier wrote: > > The shift-select-mode we added in Emacs-23 was careful to get this > right, so I think it's at least a misfeature of cua-mode. > The code in cua--pre-command-handler-1 does not try to catch > this situation, currently. > > Kim, WDYT about the patch below, which makes cua-mode use the same > mechanism as shift-select-mode? > > > Stefan > > > + (this-command-keys-shift-translated > Hi Stefan This looks much cleaner indeed. I haven't tried your patch thorughly, but it seems to work just fine, so let's go with it. Thank you for working on cua bugs! Kim