From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#10398: [PATCH] Use real vfork under Cygwin: it's fine these days Date: Wed, 11 Apr 2012 07:15:46 -0400 Message-ID: <4F8567E2.5000907@cornell.edu> References: <31890c3c686da18017fafebac19a6529ee09950d.1325166842.git.dancol@dancol.org> <83lim269h3.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1334143035 21958 80.91.229.3 (11 Apr 2012 11:17:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 11 Apr 2012 11:17:15 +0000 (UTC) Cc: 10398@debbugs.gnu.org, Lars Magne Ingebrigtsen To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Apr 11 13:17:13 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SHvXv-00071x-Ac for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2012 13:17:07 +0200 Original-Received: from localhost ([::1]:46336 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHvXu-000870-LY for geb-bug-gnu-emacs@m.gmane.org; Wed, 11 Apr 2012 07:17:06 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:44645) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHvXo-00081d-7M for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 07:17:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SHvXj-0000kk-QN for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 07:16:59 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:53893) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SHvXj-0000kd-NK for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 07:16:55 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SHvYn-0003mG-Ny for bug-gnu-emacs@gnu.org; Wed, 11 Apr 2012 07:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Apr 2012 11:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10398 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10398-submit@debbugs.gnu.org id=B10398.133414303814445 (code B ref 10398); Wed, 11 Apr 2012 11:18:01 +0000 Original-Received: (at 10398) by debbugs.gnu.org; 11 Apr 2012 11:17:18 +0000 Original-Received: from localhost ([127.0.0.1]:50427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHvY2-0003kp-Pw for submit@debbugs.gnu.org; Wed, 11 Apr 2012 07:17:18 -0400 Original-Received: from limestone3.mail.cornell.edu ([128.253.83.163]:58540) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SHvXw-0003kN-O9 for 10398@debbugs.gnu.org; Wed, 11 Apr 2012 07:17:13 -0400 X-CornellRouted: This message has been Routed already. Original-Received: from orchid.mail.cornell.edu (orchid.mail.cornell.edu [132.236.56.61]) by limestone3.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q3BBFppD020943; Wed, 11 Apr 2012 07:15:52 -0400 (EDT) Original-Received: from authusersmtp.mail.cornell.edu (granite2.mail.cornell.edu [128.253.83.142]) by orchid.mail.cornell.edu (8.14.4/8.14.4) with ESMTP id q3BBFogs025561; Wed, 11 Apr 2012 07:15:51 -0400 (EDT) Original-Received: from [192.168.1.3] (cpe-67-249-194-47.twcny.res.rr.com [67.249.194.47]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id q3BBFoTU013532 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Wed, 11 Apr 2012 07:15:50 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:10.0.1) Gecko/20120208 Thunderbird/10.0.1 In-Reply-To: <83lim269h3.fsf@gnu.org> X-PMX-CORNELL-SPAM-CHECKED: Pawpaw X-PMX-Version: 5.5.9.395186, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.4.11.110316 X-Original-Sender: kbrown@cornell.edu - Wed Apr 11 07:15:52 2012 X-PMX-CORNELL-REASON: CU_White_List_Override X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58768 Archived-At: On 4/11/2012 2:58 AM, Eli Zaretskii wrote: >> From: Lars Magne Ingebrigtsen >> Cc: 10398@debbugs.gnu.org, Eli Zaretskii >> Date: Wed, 11 Apr 2012 01:26:56 +0200 >> >> Daniel Colascione writes: >> >>> In Cygwin 1.7, vfork is an alias for fork. The vfork the #define in >>> cygwin.h was protecting against is gone. It's better to use vfork now >>> so that when Cygwin gains a new, working vfork, we use it >>> automatically. >> >> [...] >> >>> -/* vfork() interacts badly with setsid(), causing ptys to fail to >>> - change their controlling terminal */ >>> -#define vfork fork >> >> Sounds sensible to me, but I'm no exactly (ahem) a Cygwin expert. >> >> Eli, what do you think? > > Not that _I_ am a Cygwin expert, but isn't it safer to do that only > for Cygwin 1.7 and later? Ken, WDYT? I think it's a good change. And I don't think we should make an effort to support Cygwin versions earlier than 1.7. Cygwin 1.5 is no longer supported by Cygwin, so I don't see a reason for emacs to try to support it. I suspect there have been many emacs changes that are not compatible with Cygwin 1.5. Ken