From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Fri, 06 Apr 2012 18:56:31 +0200 Message-ID: <4F7F203F.90101@gmx.at> References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com><4CF7EDED.5090500@gmx.at><44FB8E26FD824BB18AE8A367F560C091@us.oracle.com><4CF8A7B2.5080306@gmx.at> <6119F1CF7E7141E28FA3CDF62C165B19@us.oracle.com> <4F7EF782.6020103@gmx.at> <4F7F0386.6030909@gmx.at> <7F573FD9970448A282AF763F35489AA3@us.oracle.com> <4F7F0FF8.7090401@gmx.at> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1333731453 29098 80.91.229.3 (6 Apr 2012 16:57:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Fri, 6 Apr 2012 16:57:33 +0000 (UTC) Cc: 7533@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Apr 06 18:57:32 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SGCTa-0002mt-D2 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Apr 2012 18:57:30 +0200 Original-Received: from localhost ([::1]:37485 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGCTZ-0007xH-D9 for geb-bug-gnu-emacs@m.gmane.org; Fri, 06 Apr 2012 12:57:29 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:37674) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGCTV-0007wL-Lr for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 12:57:26 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1SGCTT-00022q-14 for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 12:57:25 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:46251) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1SGCTS-00022l-Tg for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 12:57:22 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1SGCU5-00078o-Vv for bug-gnu-emacs@gnu.org; Fri, 06 Apr 2012 12:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 06 Apr 2012 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7533-submit@debbugs.gnu.org id=B7533.133373144827402 (code B ref 7533); Fri, 06 Apr 2012 16:58:01 +0000 Original-Received: (at 7533) by debbugs.gnu.org; 6 Apr 2012 16:57:28 +0000 Original-Received: from localhost ([127.0.0.1]:42786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1SGCTX-00077t-H0 for submit@debbugs.gnu.org; Fri, 06 Apr 2012 12:57:27 -0400 Original-Received: from mailout-de.gmx.net ([213.165.64.22]:53771) by debbugs.gnu.org with smtp (Exim 4.72) (envelope-from ) id 1SGCTO-00077U-7M for 7533@debbugs.gnu.org; Fri, 06 Apr 2012 12:57:20 -0400 Original-Received: (qmail invoked by alias); 06 Apr 2012 16:56:37 -0000 Original-Received: from 62-47-43-205.adsl.highway.telekom.at (EHLO [62.47.43.205]) [62.47.43.205] by mail.gmx.net (mp032) with SMTP; 06 Apr 2012 18:56:37 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19JTTh1qKRJeYeMcGvTQVnO9+5j8lPgjsuTY+3e/L 61VJ/q1JgsC6aB In-Reply-To: X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:58563 Archived-At: > In sum, your patch (or mine), plus `delete-frame' as the value of > `frame-auto-hide-function', is adequate. IIUC your patch works regardless of the value of `frame-auto-hide-function'. The problem of your patch is that in (if (one-window-p) (delete-frame) (delete-window)) the window for showing the buffer may have been _reused_ in which case deleting is certainly the wrong solution. > For emacs -Q: > > Without my fix and with your patch the frame is iconified, without changing > `frame-auto-hide-function'. > > Without my fix and with your patch the frame is deleted, if > `frame-auto-hide-function' is `delete-frame'. That's what this option has been meant for. I can't judge what it should default to because I hardly ever use multiple frames and never use `dired'. > My point was that users should not have to customize this option just to fix > this regression. It is reasonable for a user to prefer iconifying for frames > that s?he wants to keep, but still, naturally, want this frame to be deleted, as > it has no reason for being anymore. We can consider adding a third value for `frame-auto-hide-function'. > If you were not averse to binding a user option for a local use, perhaps you > could just bind `frame-auto-hide-function' to `delete-frame' for the duration of > the command. That should DTRT, and such a temporary binding should not bother > anyone (IMHO). If we decide that deleting the frame is the correct solution in this particular case, the most simple option is to call `quit-window' with both arguments t, thus killing the buffer as well. martin