From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#6830: widget-complete bad completions in :type 'file Date: Mon, 12 Mar 2012 01:36:41 -0700 Organization: UCLA Computer Science Department Message-ID: <4F5DB599.8050407@cs.ucla.edu> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1331541468 15224 80.91.229.3 (12 Mar 2012 08:37:48 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 12 Mar 2012 08:37:48 +0000 (UTC) To: 6830@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Mar 12 09:37:47 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S70lG-0006Nt-3L for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Mar 2012 09:37:46 +0100 Original-Received: from localhost ([::1]:52990 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S70lF-0008Sy-8e for geb-bug-gnu-emacs@m.gmane.org; Mon, 12 Mar 2012 04:37:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:56710) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S70l8-0008Sh-55 for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 04:37:44 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S70kj-0003sY-75 for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 04:37:37 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:39174) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S70kj-0003sN-3C for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 04:37:13 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1S71DZ-0007Db-M8 for bug-gnu-emacs@gnu.org; Mon, 12 Mar 2012 05:07:01 -0400 X-Loop: help-debbugs@gnu.org In-Reply-To: Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Mar 2012 09:07:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 6830 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 6830-submit@debbugs.gnu.org id=B6830.133154319827626 (code B ref 6830); Mon, 12 Mar 2012 09:07:01 +0000 Original-Received: (at 6830) by debbugs.gnu.org; 12 Mar 2012 09:06:38 +0000 Original-Received: from localhost ([127.0.0.1]:46006 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S71DA-0007BV-BH for submit@debbugs.gnu.org; Mon, 12 Mar 2012 05:06:38 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:33884) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1S71D7-0007BM-E6 for 6830@debbugs.gnu.org; Mon, 12 Mar 2012 05:06:35 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id 2BE9B39E800B for <6830@debbugs.gnu.org>; Mon, 12 Mar 2012 01:36:43 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HN6sqqrAT5EA for <6830@debbugs.gnu.org>; Mon, 12 Mar 2012 01:36:42 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id 9ADEC39E8007 for <6830@debbugs.gnu.org>; Mon, 12 Mar 2012 01:36:42 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:57702 Archived-At: That patch assumes that s1 != s2. This assumption about qsort is quite likely true on Windows but it's not guaranteed by the C standard, and for portability it's better to play it safe and stick with the pattern that's already in the code. I installed this further patch: === modified file 'src/ChangeLog' --- src/ChangeLog 2012-03-12 06:34:32 +0000 +++ src/ChangeLog 2012-03-12 08:27:25 +0000 @@ -1,3 +1,7 @@ +2012-03-12 Paul Eggert + + * buffer.c (compare_overlays): Don't assume args differ (Bug#6830). + 2012-03-12 Chong Yidong * eval.c (inhibit_lisp_code): Rename from === modified file 'src/buffer.c' --- src/buffer.c 2012-03-09 16:46:25 +0000 +++ src/buffer.c 2012-03-12 08:27:25 +0000 @@ -2868,7 +2868,9 @@ between "equal" overlays. The result can still change between invocations of Emacs, but it won't change in the middle of `find_field' (bug#6830). */ - return XHASH (s1->overlay) < XHASH (s2->overlay) ? -1 : 1; + if (XHASH (s1->overlay) != XHASH (s2->overlay)) + return XHASH (s1->overlay) < XHASH (s2->overlay) ? -1 : 1; + return 0; } /* Sort an array of overlays by priority. The array is modified in place.