From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#10626: Should configure fail if pkg-config fails? Date: Sat, 28 Jan 2012 01:07:50 -0800 Organization: UCLA Computer Science Department Message-ID: <4F23BAE6.5080906@cs.ucla.edu> References: <4F1F3019.8060808@cs.ucla.edu> <4F1F356F.9040501@cs.ucla.edu> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1327769668 16537 80.91.229.3 (28 Jan 2012 16:54:28 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 28 Jan 2012 16:54:28 +0000 (UTC) Cc: 10626@debbugs.gnu.org To: Jordi =?UTF-8?Q?Guti=C3=A9rrez?= Hermoso Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jan 28 17:54:23 2012 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RrBXj-0007IK-9C for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2012 17:54:23 +0100 Original-Received: from localhost ([::1]:44339 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4Gq-0001Bg-Me for geb-bug-gnu-emacs@m.gmane.org; Sat, 28 Jan 2012 04:08:28 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:49456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4Gl-0001Ba-P9 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:08:27 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4Gi-0006TQ-5s for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:08:23 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:42087) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4Gi-0006TM-38 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:08:20 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.72) (envelope-from ) id 1Rr4HN-0005to-V3 for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 28 Jan 2012 09:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 10626 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-Cc: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.132774172622649 (code B ref -1); Sat, 28 Jan 2012 09:09:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 28 Jan 2012 09:08:46 +0000 Original-Received: from localhost ([127.0.0.1]:47474 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4H8-0005tE-14 for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:08:46 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:58565) by debbugs.gnu.org with esmtp (Exim 4.72) (envelope-from ) id 1Rr4H4-0005t2-JV for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:08:44 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4GH-0006Ro-3F for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:07:54 -0500 Original-Received: from lists.gnu.org ([140.186.70.17]:35940) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GH-0006Rk-1l for submit@debbugs.gnu.org; Sat, 28 Jan 2012 04:07:53 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:49382) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GF-0001BT-TA for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:52 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Rr4GE-0006RS-4q for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:51 -0500 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]:34664) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Rr4GD-0006RM-OZ for bug-gnu-emacs@gnu.org; Sat, 28 Jan 2012 04:07:50 -0500 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id D1C4FA60063; Sat, 28 Jan 2012 01:07:48 -0800 (PST) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 9zJhslGumkRY; Sat, 28 Jan 2012 01:07:48 -0800 (PST) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E48A6A60034; Sat, 28 Jan 2012 01:07:47 -0800 (PST) User-Agent: Mozilla/5.0 (X11; Linux i686; rv:9.0) Gecko/20111229 Thunderbird/9.0 In-Reply-To: X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.13 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:56125 Archived-At: On 01/24/2012 06:15 PM, Jordi Guti=C3=A9rrez Hermoso wrote: > it shouldn't assume that GTK+ is working correctly if > pkg-config returns nonzero exit status. True enough. Here's a proposed patch, which I'd like to install into the trunk. I'm CC'ing this to bug-gnu-emacs instead of to emacs-devel, so that it has a proper bug number. =3D=3D=3D modified file 'ChangeLog' --- ChangeLog 2012-01-19 07:21:25 +0000 +++ ChangeLog 2012-01-28 09:04:13 +0000 @@ -1,3 +1,11 @@ +2012-01-28 Paul Eggert + + Check pkg-config exit status when configuring. + * configure.in (PKG_CHECK_MODULES): Do not assume that pkg-config + works; check its exit status. Problem reported by Jordi Guti=C3=A9rrez + Hermoso in + . + 2012-01-16 Juanma Barranquero =20 * .bzrignore: Ignore etc/__pycache__. =3D=3D=3D modified file 'configure.in' --- configure.in 2012-01-19 07:21:25 +0000 +++ configure.in 2012-01-28 09:04:13 +0000 @@ -1124,17 +1124,14 @@ if $PKG_CONFIG --atleast-pkgconfig-version $PKG_CONFIG_MIN_VERSION;= then AC_MSG_CHECKING(for $2) =20 - if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD; then - AC_MSG_RESULT(yes) + if $PKG_CONFIG --exists "$2" 2>&AS_MESSAGE_LOG_FD && + $1_CFLAGS=3D`$PKG_CONFIG --cflags "$2" 2>&AS_MESSAGE_LOG_FD` && + $1_LIBS=3D`$PKG_CONFIG --libs "$2" 2>&AS_MESSAGE_LOG_FD`; then + + $1_CFLAGS=3D`AS_ECHO(["$$1_CFLAGS"]) | sed -e 's,///*,/,g'` + $1_LIBS=3D`AS_ECHO(["$$1_LIBS"]) | sed -e 's,///*,/,g'` + AC_MSG_RESULT([yes CFLAGS=3D'$$1_CFLAGS' LIBS=3D'$$1_LIBS']) succeeded=3Dyes - - AC_MSG_CHECKING($1_CFLAGS) - $1_CFLAGS=3D`$PKG_CONFIG --cflags "$2"|sed -e 's,///*,/,g'` - AC_MSG_RESULT($$1_CFLAGS) - - AC_MSG_CHECKING($1_LIBS) - $1_LIBS=3D`$PKG_CONFIG --libs "$2"|sed -e 's,///*,/,g'` - AC_MSG_RESULT($$1_LIBS) else AC_MSG_RESULT(no) $1_CFLAGS=3D""