From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#64821: 30.0.50; write-region errs when overwriting an already open file Date: Thu, 27 Jul 2023 19:47:46 +0200 Message-ID: <4F213DB7-96C1-48F2-AE87-F22136C0848E@gmail.com> References: <2B783248-53AF-4486-8208-74A6B0A517EE@gmail.com> <83mszhl3j1.fsf@gnu.org> Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="17316"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 64821@debbugs.gnu.org, yantar92@gmail.com To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jul 27 20:03:14 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qP5KR-0004Hw-Vl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 27 Jul 2023 20:03:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qP55p-0002VP-G2; Thu, 27 Jul 2023 13:48:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qP55n-0002S7-Qu for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 13:48:03 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qP55n-0005Ny-JL for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 13:48:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qP55n-0002wC-5W for bug-gnu-emacs@gnu.org; Thu, 27 Jul 2023 13:48:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 27 Jul 2023 17:48:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64821 X-GNU-PR-Package: emacs Original-Received: via spool by 64821-submit@debbugs.gnu.org id=B64821.169048007911250 (code B ref 64821); Thu, 27 Jul 2023 17:48:03 +0000 Original-Received: (at 64821) by debbugs.gnu.org; 27 Jul 2023 17:47:59 +0000 Original-Received: from localhost ([127.0.0.1]:43106 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qP55i-0002vH-Ci for submit@debbugs.gnu.org; Thu, 27 Jul 2023 13:47:58 -0400 Original-Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]:50568) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qP55d-0002u0-P6 for 64821@debbugs.gnu.org; Thu, 27 Jul 2023 13:47:56 -0400 Original-Received: by mail-lf1-x132.google.com with SMTP id 2adb3069b0e04-4fb7589b187so2155893e87.1 for <64821@debbugs.gnu.org>; Thu, 27 Jul 2023 10:47:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1690480068; x=1691084868; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=5xMvlVL64nQ5Lq044g5D97wB2m4bDE+a7ZrBnxgvKGg=; b=IEoY8UBd2XFQo4WmB+PCJ6hdegPcUBNlWDnvH+JIyNjVRNnbCe+MIUvWLItl60fRMF 0DaKoectNswnh7B16f8pRLbXegkjT1A8Ib50i24gvxh7yF8TdWsvtuHTX9vy64M0g1e0 vuAIxsPerveb3XsAAud6nQpT196OxevwprSV7v8WL9AsYgTuFzdPrWFjsep8YVTcfbEj t553ln5Fr0QORlOtbbyss7WRIzzpVO0b+TLtPVHlfk1t9yTQLq/ktlp0gWy9h51XVCQQ PbjIb197p/lFV0nXIYRUYTS4wHR4n6wl92Qg7ckSw4up2Xxx0PQ3ishAuT6U8cfj7QzL CHDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690480068; x=1691084868; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=5xMvlVL64nQ5Lq044g5D97wB2m4bDE+a7ZrBnxgvKGg=; b=fwq65dOLrycntF5wVCwY3a0mERWkbaAOwYJhSoxrv/yFV83QtvzFa2lyh2KSNtjcbB JwuCrsC6xFHnwN/HAq9fqCOmmT27WLKfEQsblJHn8KgjWF1TMxMcqjT6qLAzg+Ekk9jx jjCYMF0zohekmhOL/bXb1AzPPES3rzCy/Jf1O76OuhN5GSzlJPPr23y9p5bZlS36M6F7 xkRUBdJmpNcuXOwTfCNrQPg3emz7wOmWIDMDuhdluhsAj5NCTAQrYgOUwk3mUH8Afjuu TuwVddo4C4A0o6X5iiDPANYTYkkhxIfW3nOO28TmaECa5HuB3T/Vw5kG2q1vrzLWBWUq 0ybg== X-Gm-Message-State: ABy/qLbtjByxpSJDK/r6r2lTDa8jJ/8cjk9AQXqu2/vF+7NqNCYvmgZE jJstbEEIMM4vEjcgPehZqqQ= X-Google-Smtp-Source: APBJJlGxK/nHc931+gFOuHsud23QeUCfjViEAjFoN9Uos2K9OKKoQ+sAT0GJVVU6iI6EhVOvRcAr4A== X-Received: by 2002:a05:6512:33c9:b0:4f8:7772:3dfd with SMTP id d9-20020a05651233c900b004f877723dfdmr2597061lfg.11.1690480067504; Thu, 27 Jul 2023 10:47:47 -0700 (PDT) Original-Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id c12-20020ac2530c000000b004fdc8b0ee13sm407400lfh.172.2023.07.27.10.47.47 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 Jul 2023 10:47:47 -0700 (PDT) In-Reply-To: <83mszhl3j1.fsf@gnu.org> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:266214 Archived-At: 27 juli 2023 kl. 18.31 skrev Eli Zaretskii : > Is that this line: >=20 > (with-current-buffer (get-file-buffer (file-truename = filename)) > (set-visited-file-modtime)) Right, and it's probably because ERT creates temporary files in = /var/something but on macOS, /var is a symlink to /private/var. In the = lines above, filename (and file-truename) is the "/private/var/..." = version. Thus get-file-buffer won't return anything because buffer-file-name = contains the non-true name, "/var/...". I have no idea if this is the right solution (probably not) but it makes = filelock-tests all pass: --- a/test/src/filelock-tests.el +++ b/test/src/filelock-tests.el @@ -38,8 +38,8 @@ filelock-tests--fixture Finally, delete the buffer and the test directory." (declare (debug (body))) `(ert-with-temp-directory temp-dir - (let ((name (concat (file-name-as-directory temp-dir) - "userfile")) + (let ((name (file-truename (concat (file-name-as-directory = temp-dir) + "userfile"))) (create-lockfiles t)) (with-temp-buffer (setq buffer-file-name name