unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: "Andreas Röhler" <andreas.roehler@online.de>
To: 10546@debbugs.gnu.org
Subject: bug#10546: completion-at-point bug
Date: Wed, 18 Jan 2012 19:50:56 +0100	[thread overview]
Message-ID: <4F171490.8000704@online.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 250 bytes --]

Hi,

get wrong error messages like

let*: Wrong type argument: listp, 16

from `completion-at-point' in cases `tab-to-tab-stop'
sends back a number - the column reached.

;;;;;;;;;
bug pertains to Emacs-23 and 24
patch attached

thanks all,

Andreas

[-- Attachment #2: completion-at-point.patch --]
[-- Type: text/x-patch, Size: 1091 bytes --]

--- emacs-23.3.90/lisp/minibuffer.el	2012-01-11 13:35:01.000000000 +0100
+++ minibuffer.el	2012-01-18 18:57:37.561110910 +0100
@@ -1198,15 +1198,16 @@
               'completion-at-point-functions)))
     (cond
      ((functionp res) (funcall res))
-     (res
-      (let* ((plist (nthcdr 3 res))
-             (start (nth 0 res))
-             (end (nth 1 res))
-             (completion-annotate-function
-              (or (plist-get plist :annotation-function)
-                  completion-annotate-function)))
-        (completion-in-region start end (nth 2 res)
-                              (plist-get plist :predicate)))))))
+     (unless (numberp res)
+       (res
+        (let* ((plist (nthcdr 3 res))
+               (start (nth 0 res))
+               (end (nth 1 res))
+               (completion-annotate-function
+                (or (plist-get plist :annotation-function)
+                    completion-annotate-function)))
+          (completion-in-region start end (nth 2 res)
+                                (plist-get plist :predicate))))))))
 
 ;;; Key bindings.
 

             reply	other threads:[~2012-01-18 18:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-18 18:50 Andreas Röhler [this message]
2012-01-18 21:22 ` bug#10546: completion-at-point bug Stefan Monnier
2012-01-22 14:10   ` Andreas Röhler
2012-01-22 21:22     ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F171490.8000704@online.de \
    --to=andreas.roehler@online.de \
    --cc=10546@debbugs.gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).