From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Eric M. Ludlam" Newsgroups: gmane.emacs.bugs Subject: bug#10275: speedbar highlights first selected item in speedbar-highlight-face Date: Wed, 14 Dec 2011 18:06:18 -0500 Message-ID: <4EE92BEA.2080102@siege-engine.com> References: <4EE8DB96.9020500@gmx.at> <4EE8E8FF.70209@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1323911087 14715 80.91.229.12 (15 Dec 2011 01:04:47 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 15 Dec 2011 01:04:47 +0000 (UTC) Cc: 10275@debbugs.gnu.org, Juanma Barranquero , "Eric M. Ludlam" To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 15 02:04:43 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RazkY-0008Ua-K7 for geb-bug-gnu-emacs@m.gmane.org; Thu, 15 Dec 2011 02:04:42 +0100 Original-Received: from localhost ([::1]:38569 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RazkS-0002d5-SO for geb-bug-gnu-emacs@m.gmane.org; Wed, 14 Dec 2011 20:04:36 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:38438) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RazR8-0007V9-Oj for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 19:44:39 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RazR7-0003cU-8b for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 19:44:38 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37792) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RazR7-0003cQ-72 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 19:44:37 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RazSV-0005Hh-G5 for bug-gnu-emacs@gnu.org; Wed, 14 Dec 2011 19:46:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: "Eric M. Ludlam" Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 15 Dec 2011 00:46:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10275-submit@debbugs.gnu.org id=B10275.132390990520221 (code B ref 10275); Thu, 15 Dec 2011 00:46:03 +0000 Original-Received: (at 10275) by debbugs.gnu.org; 15 Dec 2011 00:45:05 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RazRY-0005G2-MS for submit@debbugs.gnu.org; Wed, 14 Dec 2011 19:45:05 -0500 Original-Received: from mail-qw0-f51.google.com ([209.85.216.51]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RaxvO-00033M-49 for 10275@debbugs.gnu.org; Wed, 14 Dec 2011 18:07:47 -0500 Original-Received: by qadz3 with SMTP id z3so970685qad.3 for <10275@debbugs.gnu.org>; Wed, 14 Dec 2011 15:06:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=SztZ3qneAEO3Xnx5R/k0+vR3UtTBlq2LFK1cTm4d5QU=; b=nuumb5U89B3SBjtWU8jSZhE/k4Ji0RNQewx7xSnq3m9ftHiGlg0uyfzLFAedJspi1h Ri1gabNKZ1LIwhxYzTPunw6eA/0IoAVtlVjf/neTToPZ8+fCcWZGB/QiNIStAANOsX1m Per/rkA10iC5zgMk+UYC80Bjwe5vH3SboHzOk= Original-Received: by 10.224.185.6 with SMTP id cm6mr1213557qab.89.1323903979611; Wed, 14 Dec 2011 15:06:19 -0800 (PST) Original-Received: from [192.168.1.201] (pool-71-184-213-12.bstnma.fios.verizon.net. [71.184.213.12]) by mx.google.com with ESMTPS id dj8sm8649063qab.19.2011.12.14.15.06.18 (version=SSLv3 cipher=OTHER); Wed, 14 Dec 2011 15:06:19 -0800 (PST) User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.3a1pre) Gecko/20091222 Shredder/3.1a1pre In-Reply-To: <4EE8E8FF.70209@gmx.at> X-Mailman-Approved-At: Wed, 14 Dec 2011 19:45:02 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 14 Dec 2011 19:46:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-Mailman-Approved-At: Wed, 14 Dec 2011 20:04:34 -0500 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54970 Archived-At: On 12/14/2011 01:20 PM, martin rudalics wrote: > > IOW, the bug is in removing the highlight when selecting subsequent > items. > > Not really. FWIW the bug happens because `handle-switch-frame' runs > `pre-command-hook', something Eric probably didn't expect. Switching > the frame is needed because the mouse click selects the speedbar frame > and we immediately want to return to the frame where the source file is > shown. But I don't understand why de-highlighting doesn't occur when > hitting RET in the speedbar or switching to another buffer with the > mouse. I wrote that bit of code a long time ago. The idea is to just show the line of interest in an easy to identify way, but have the highlight go away on the next keypress. It seems like all the frame switching running the hook is defeating the mechanism it was using. It could be that in speedbar-tag-find just swapping the last two lines is sufficient to move the post-command-hook execution to the right time. Such a patch should be sent to the Emacs maintainers, as I haven't been maintaining speedbar directly lately. Eric