unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#9852: 24.0.90; pthread_sigmask() check is bogus when HAVE_PTHREAD is defined
@ 2011-10-23 21:24 Nali Toja
  2011-10-24  2:44 ` bug#9852: " Paul Eggert
  0 siblings, 1 reply; 4+ messages in thread
From: Nali Toja @ 2011-10-23 21:24 UTC (permalink / raw)
  To: 9852

emacs configure detects (via gnulib) pthread_sigmask even when there is
a stub in libc, marks it broken with

  PTHREAD_SIGMASK_INEFFECTIVE
  PTHREAD_SIGMASK_UNBLOCK_BUG

and links with LIB_PTHREAD during build. What if the version in
LIB_PTHREAD is not broken? gnulib would still wrap it with code
that may not work as expected.
  
forwarding http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/161911
it adds -lpthread to LDFLAGS as a workaround
--
In GNU Emacs 24.0.90.9 (amd64-unknown-freebsd9.9)
 of 2011-10-23 on hidden
configured using `configure  '--without-x'





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#9852: pthread_sigmask() check is bogus when HAVE_PTHREAD is defined
  2011-10-23 21:24 bug#9852: 24.0.90; pthread_sigmask() check is bogus when HAVE_PTHREAD is defined Nali Toja
@ 2011-10-24  2:44 ` Paul Eggert
  2011-10-24  3:30   ` Nali Toja
  0 siblings, 1 reply; 4+ messages in thread
From: Paul Eggert @ 2011-10-24  2:44 UTC (permalink / raw)
  To: Nali Toja; +Cc: 9852

Thanks for reporting that.  I think the bug is that configure.in is
invoking AC_CHECK_LIB in such a way that LIBS is not affected.
This would be a problem regardless of the FreeBSD issue, but
I expect it's causing the FreeBSD issue as well.  I committed a fix
into the trunk as bzr 106173; could you please give it a try
and let us know how it goes?  Thanks.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#9852: pthread_sigmask() check is bogus when HAVE_PTHREAD is defined
  2011-10-24  2:44 ` bug#9852: " Paul Eggert
@ 2011-10-24  3:30   ` Nali Toja
  2011-10-24  3:33     ` Paul Eggert
  0 siblings, 1 reply; 4+ messages in thread
From: Nali Toja @ 2011-10-24  3:30 UTC (permalink / raw)
  To: Paul Eggert; +Cc: 9852

Paul Eggert <eggert@cs.ucla.edu> writes:

> Thanks for reporting that.  I think the bug is that configure.in is
> invoking AC_CHECK_LIB in such a way that LIBS is not affected.
> This would be a problem regardless of the FreeBSD issue, but
> I expect it's causing the FreeBSD issue as well.  I committed a fix
> into the trunk as bzr 106173; could you please give it a try
> and let us know how it goes?  Thanks.

Yep, 106173 fixes the issue. Both the FreeBSD port's snapshot with the
patch from the commit and emacs trunk detect pthread_sigmask() correctly.





^ permalink raw reply	[flat|nested] 4+ messages in thread

* bug#9852: pthread_sigmask() check is bogus when HAVE_PTHREAD is defined
  2011-10-24  3:30   ` Nali Toja
@ 2011-10-24  3:33     ` Paul Eggert
  0 siblings, 0 replies; 4+ messages in thread
From: Paul Eggert @ 2011-10-24  3:33 UTC (permalink / raw)
  To: Nali Toja; +Cc: 9852-done

Thanks for checking; I'm marking this as done.





^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-10-24  3:33 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-23 21:24 bug#9852: 24.0.90; pthread_sigmask() check is bogus when HAVE_PTHREAD is defined Nali Toja
2011-10-24  2:44 ` bug#9852: " Paul Eggert
2011-10-24  3:30   ` Nali Toja
2011-10-24  3:33     ` Paul Eggert

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).