unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Sam James <sam@gentoo.org>
To: Eli Zaretskii <eliz@gnu.org>
Cc: 57636@debbugs.gnu.org
Subject: bug#57636: [PATCH] Recognize zstandard (.zst) suffix in lisp/info.el
Date: Thu, 8 Sep 2022 03:10:21 +0100	[thread overview]
Message-ID: <4E6F1B45-BFA6-4B9F-9F14-7A065405A3EC@gentoo.org> (raw)
In-Reply-To: <834jxjifhd.fsf@gnu.org>

[-- Attachment #1: Type: text/plain, Size: 1321 bytes --]



> On 7 Sep 2022, at 12:35, Eli Zaretskii <eliz@gnu.org> wrote:
> 
>> Cc: Sam James <sam@gentoo.org>
>> From: Sam James <sam@gentoo.org>
>> Date: Wed,  7 Sep 2022 05:00:40 +0100
>> 
>> * lisp/info.el (Info-suffix-list): Recognize .zst file extension from the
>> zstd compression tool. This allos reading Info pages compressed with zstandard.
>> ---
>> lisp/info.el | 4 ++++
>> 1 file changed, 4 insertions(+)
>> 
>> diff --git a/lisp/info.el b/lisp/info.el
>> index 1a58910c3a..fdbe1f9b90 100644
>> --- a/lisp/info.el
>> +++ b/lisp/info.el
>> @@ -451,6 +451,7 @@ or `Info-virtual-nodes'."
>>        (".info.z"    . "gunzip")
>>        (".info.bz2"  . ("bzip2" "-dc"))
>>        (".info.xz"   . "unxz")
>> +       (".info.zst"  . ("unzstd" "--rm" "-q"))
> 
> Thanks, but I don't think I understand the --rm part: these commands
> aren't supposed to replace the original compressed file with its
> decompressed version, they are supposed to write the decompressed text
> to stdout, where it will be read by Emacs and displayed, and leave the
> original compressed files alone.
> 
> So I think you want "-dc", not "--rm -q".  Am I missing something?

You're missing nothing and you're exactly right. Apologies
tor the error -- that seems obvious now!

I'll send a fixed version shortly.

[-- Attachment #2: Message signed with OpenPGP --]
[-- Type: application/pgp-signature, Size: 358 bytes --]

  reply	other threads:[~2022-09-08  2:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-09-07  4:00 bug#57636: [PATCH] Recognize zstandard (.zst) suffix in lisp/info.el Sam James
2022-09-07 11:35 ` Eli Zaretskii
2022-09-08  2:10   ` Sam James [this message]
2022-09-08  3:03     ` Sam James
2022-09-08  8:52       ` Eli Zaretskii
2022-09-09  4:21         ` Sam James
2022-09-08  2:57   ` bug#57665: " Sam James
2022-09-08  2:59     ` Sam James

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E6F1B45-BFA6-4B9F-9F14-7A065405A3EC@gentoo.org \
    --to=sam@gentoo.org \
    --cc=57636@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).