From: Ken Brown <kbrown@cornell.edu>
To: Eli Zaretskii <eliz@gnu.org>
Cc: "9273@debbugs.gnu.org" <9273@debbugs.gnu.org>
Subject: bug#9273: 23.3; malloc initialization should (sometimes) happen at runtime
Date: Fri, 12 Aug 2011 08:18:39 -0400 [thread overview]
Message-ID: <4E451A1F.4060409@cornell.edu> (raw)
In-Reply-To: <831uwqyidi.fsf@gnu.org>
On 8/12/2011 7:33 AM, Eli Zaretskii wrote:
>> Date: Fri, 12 Aug 2011 06:10:35 -0400
>> From: Ken Brown<kbrown@cornell.edu>
>> CC: "9273@debbugs.gnu.org"<9273@debbugs.gnu.org>
>>
>> On 8/12/2011 2:54 AM, Eli Zaretskii wrote:
>>>> Date: Thu, 11 Aug 2011 17:45:41 -0400
>>>> From: Ken Brown<kbrown@cornell.edu>
>>>> CC: "9273@debbugs.gnu.org"<9273@debbugs.gnu.org>
>>>>
>>>> The problem was that realloc got called on memory that had been
>>>> allocated prior to dumping, and the malloc information that was used
>>>> then had disappeared.
>>>
>>> Can you show the code which called realloc on that memory? I'm
>>> surprised that Emacs does that, but perhaps I'm missing something.
>>
>> Here's the code that I stumbled across (as a result of a SEGV). I
>> haven't checked to see if there are other examples. From terminal.c:
>>
>> /* Deletes the bootstrap terminal device.
>> Called through delete_terminal_hook. */
>>
>> static void
>> delete_initial_terminal (struct terminal *terminal)
>> {
>> if (terminal != initial_terminal)
>> abort ();
>>
>> delete_terminal (terminal);
>> initial_terminal = NULL;
>> }
>
> delete_terminal doesn't call realloc, it just calls xfree.
Maybe I mis-remembered where the call to realloc is. I'll reproduce it
later and let you know. (I don't have time at the moment.) But I
assure you that I did a backtrace showing that realloc was called on
something related to terminals.
> Do the problems with the Cygwin build go away if the call to
> delete_terminal is commented out?
No. At the very least, I have to force reinitialization of malloc.
Otherwise the BLOCK macro yields wrong results that lead to infinite
looping or crashing. After reinitialization, I have to be able to
handle calls to free() on memory allocated prior to dumping. Probably
it's OK to just ignore such calls. If I can also take care of calls to
realloc too, everything will be OK.
Ken
next prev parent reply other threads:[~2011-08-12 12:18 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-09 20:09 bug#9273: 23.3; malloc initialization should (sometimes) happen at runtime Ken Brown
2011-08-10 0:24 ` Richard Stallman
2011-08-10 15:56 ` Eli Zaretskii
2011-08-10 17:52 ` Ken Brown
2011-08-10 18:10 ` Eli Zaretskii
2011-08-10 18:49 ` Ken Brown
2011-08-11 21:45 ` Ken Brown
2011-08-12 6:54 ` Eli Zaretskii
2011-08-12 10:10 ` Ken Brown
2011-08-12 11:33 ` Eli Zaretskii
2011-08-12 12:18 ` Ken Brown [this message]
2011-08-12 20:24 ` Ken Brown
2011-08-13 8:05 ` Eli Zaretskii
2011-08-13 13:48 ` Ken Brown
2011-08-13 14:41 ` Eli Zaretskii
2011-08-13 14:53 ` Ken Brown
2011-08-13 15:07 ` Stefan Monnier
2011-08-13 15:33 ` Ken Brown
2011-08-13 19:19 ` Stefan Monnier
2011-08-14 3:13 ` Ken Brown
2011-08-16 13:30 ` Ken Brown
2011-08-12 23:51 ` grischka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E451A1F.4060409@cornell.edu \
--to=kbrown@cornell.edu \
--cc=9273@debbugs.gnu.org \
--cc=eliz@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).