From: "Mattias Engdegård" <mattias.engdegard@gmail.com>
To: Xiyue Deng <manphiz@gmail.com>
Cc: Eli Zaretskii <eliz@gnu.org>, 66782-done@debbugs.gnu.org
Subject: bug#66782: 29.1; ERT tests report test redefined depending on loading sequence
Date: Fri, 3 Nov 2023 18:14:24 +0100 [thread overview]
Message-ID: <4E3AEBFB-5041-44D5-A14B-DC5E3B9E9AFA@gmail.com> (raw)
In-Reply-To: <87bkcbizns.fsf@debian-hx90.lan>
2 nov. 2023 kl. 23.00 skrev Xiyue Deng <manphiz@gmail.com>:
> 1) Tests that are different but use the same test name.
>
> 2) There is no tests sharing the same name, but caused by double loading
> the same test unit through a dependency by require.
>
> Case 1 happens a lot in the wild and has caused many FTBFS bugs in
> Debian after upgrading Emacs to 29.1 (e.g. [1][2]), and the fix is
> simply to rename the tests.
Thank you, I'm happy to hear that the check actually caught the kind of errors it was supposed to find.
> As a matter of fact I've spent a non-trivial time
> trying to debug this one as it depends on the loading sequence which
> caused the failure to be flaky. So I hope my proposed change can help
> people on realizing that it's case 2 a bit faster.
That's fine, adding something like what you suggested doesn't cost us anything: now done on master (425d23fbea).
I'm closing the bug now, but do say if there is something I forgot.
next prev parent reply other threads:[~2023-11-03 17:14 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-27 20:59 bug#66782: 29.1; ERT tests reports test redefined depending on loading sequence Xiyue Deng
2023-10-28 6:32 ` Eli Zaretskii
2023-10-28 9:39 ` bug#66782: 29.1; ERT tests report " Xiyue Deng
2023-10-28 9:48 ` Eli Zaretskii
2023-10-28 11:14 ` Xiyue Deng
2023-10-28 11:34 ` Eli Zaretskii
2023-10-28 11:50 ` Xiyue Deng
2023-10-28 12:03 ` Eli Zaretskii
2023-10-28 12:46 ` Mattias Engdegård
2023-10-28 21:19 ` Xiyue Deng
2023-10-29 12:09 ` Mattias Engdegård
2023-10-29 21:53 ` Xiyue Deng
2023-10-30 12:04 ` Mattias Engdegård
2023-10-30 20:47 ` Xiyue Deng
2023-11-02 17:17 ` Xiyue Deng
2023-11-02 18:56 ` Mattias Engdegård
2023-11-02 22:00 ` Xiyue Deng
2023-11-03 17:14 ` Mattias Engdegård [this message]
2023-11-03 17:56 ` Xiyue Deng
2023-11-04 8:51 ` Eli Zaretskii
2023-10-28 19:41 ` Xiyue Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E3AEBFB-5041-44D5-A14B-DC5E3B9E9AFA@gmail.com \
--to=mattias.engdegard@gmail.com \
--cc=66782-done@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=manphiz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).