unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Juanma Barranquero <lekktu@gmail.com>
Cc: 8911@debbugs.gnu.org
Subject: bug#8911: bs-cycle-next deletes window in some cases.
Date: Tue, 21 Jun 2011 15:37:52 +0200	[thread overview]
Message-ID: <4E009EB0.1050903@gmx.at> (raw)
In-Reply-To: <BANLkTinYNL9hNL00hWgo6Yt5Oo2Ayy78eA@mail.gmail.com>

 > With current trunk.
 >
 >   emacs -Q -l bs
 >   C-x 2
 >   M-x bs-cycle-next <RET>
 >
 > and the bottom window is deleted.

IIUC this happens because of this code

	(unless (window-dedicated-p (selected-window))
	  ;; We don't want the frame iconified if the only window in the frame
	  ;; happens to be dedicated; let's get the error from switch-to-buffer
	  (bury-buffer))
	(switch-to-buffer next)

in `bs-cycle-next' and `bury-buffer' can now delete a window showing the
buffer provided this buffer was the first to appear in a window.

`bs-cycle-next' is probably not to blame because it just wants to make
sure that the buffer is not chosen again soon for displaying it.  So we
have a number of ways to restore the old behavior, namely

- have `bs-cycle-next' call `unrecord-buffer' instead of `bury-buffer',

- have `bury-buffer' only delete dedicated windows as before,

- give `bury-buffer' an extra argument which allows (or forbids) to
   delete the selected window (or corresponding frame),

- make sure that `bury-buffer' deletes only automatically created
   windows (much like the recent option `frame-auto-delete').

Personally, I have no preference since I never understood the
"additional" semantics of `bury-buffer'.  Earlier versions of this used
to iconify frames which some people on this list disliked severely so I
removed it.  So far no one missed this issue, but maybe I shall restore
it as well?

martin





  reply	other threads:[~2011-06-21 13:37 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 11:01 bug#8911: bs-cycle-next deletes window in some cases Juanma Barranquero
2011-06-21 13:37 ` martin rudalics [this message]
2011-06-21 14:00   ` Juanma Barranquero
2011-06-21 14:42     ` martin rudalics
2011-06-21 15:02       ` Juanma Barranquero
2011-06-21 16:12         ` martin rudalics
2011-06-21 16:21           ` Juanma Barranquero
2011-06-21 16:28         ` Stefan Monnier
2011-06-21 16:37           ` Juanma Barranquero
2011-06-22  2:14           ` Stefan Monnier
2011-06-22  2:31             ` Juanma Barranquero
2011-06-22 20:11               ` Stefan Monnier
2011-06-21 16:22     ` Stefan Monnier
2011-06-21 16:28       ` Juanma Barranquero
2011-06-21 17:15         ` Drew Adams
2011-06-22  2:11           ` Stefan Monnier
2011-06-22  2:53             ` Drew Adams
2011-06-22  3:13               ` Drew Adams
2011-06-22 20:07               ` Stefan Monnier
2011-06-22 22:01                 ` Drew Adams
2011-06-23 21:55                   ` Stefan Monnier
2011-06-25 21:24                     ` Juanma Barranquero
2011-06-26  9:29                       ` martin rudalics
2011-06-26 11:25                         ` Juanma Barranquero
2011-06-27  1:30                           ` Stefan Monnier
2011-06-27  1:53                             ` Juanma Barranquero
2011-06-27  7:00                               ` martin rudalics
2011-06-27  9:38                                 ` Juanma Barranquero
2011-06-27 12:46                                   ` martin rudalics
2011-06-27 14:01                                     ` Juanma Barranquero
2011-06-27 14:12                                       ` martin rudalics
2011-06-27 14:22                                         ` Juanma Barranquero
2011-06-27 20:11                                           ` Juanma Barranquero
2011-06-29  3:27                               ` Stefan Monnier
2011-06-29  3:57                                 ` Juanma Barranquero
2011-06-30 17:02                                   ` Stefan Monnier
2011-06-30 18:50                                     ` Juanma Barranquero
2011-07-01 12:07                                       ` Juanma Barranquero
2011-06-29  7:11                                 ` martin rudalics
2011-06-30 17:06                                   ` Stefan Monnier
2011-06-29 11:36                                 ` Juanma Barranquero
2011-06-29 15:36                                 ` Drew Adams
2011-06-29 18:21                                   ` Drew Adams
2011-06-30  7:00                                     ` martin rudalics
2011-06-30 15:31                                       ` Drew Adams
2011-06-22  2:07         ` Stefan Monnier
2011-06-21 16:36       ` martin rudalics
2011-06-21 17:07       ` Drew Adams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E009EB0.1050903@gmx.at \
    --to=rudalics@gmx.at \
    --cc=8911@debbugs.gnu.org \
    --cc=lekktu@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).