unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
* bug#8288: vc-git slow on large repository
@ 2011-03-18 19:32 S Boucher
       [not found] ` <handler.8288.B.130047675931219.ack@debbugs.gnu.org>
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: S Boucher @ 2011-03-18 19:32 UTC (permalink / raw)
  To: 8288

find-file and save-buffer are slow.  It appears to be due to vc-git-state.

vc-git-state calls:

     git diff-index -z HEAD -- file.cpp

Which is slow on large git repository, such as webkit.

The question is then whether or not vc-git.el can be more clever than it is now.

I don't have the answer to this.


System:
ubuntu 10.04 64bit
emacs 23.2
git 1.7.0.4
8G of ram
Intel Core i7 (8 processors)







^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#8288: Acknowledgement (vc-git slow on large repository)
       [not found] ` <handler.8288.B.130047675931219.ack@debbugs.gnu.org>
@ 2011-03-19  2:54   ` S Boucher
  2011-03-19  7:32     ` Andreas Schwab
  0 siblings, 1 reply; 5+ messages in thread
From: S Boucher @ 2011-03-19  2:54 UTC (permalink / raw)
  To: 8288

I think 'git diff-index -z HEAD -- <file>' could be replaced with 'git status -z 
--porcelain <file>' in vc-git-state.

It is 10times faster on a large webkit repository.




----- Original Message ----
> From: GNU bug Tracking System <help-debbugs@gnu.org>
> To: S Boucher <stbya@yahoo.com>
> Sent: Fri, March 18, 2011 3:33:02 PM
> Subject: bug#8288: Acknowledgement (vc-git slow on large repository)
> 
> Thank you for filing a new bug report with GNU.
> 
> This is an automatically  generated reply to let you know your message
> has been received.
> 
> Your  message is being forwarded to the package maintainers and other
> interested  parties for their attention; they will reply in due course.
> 
> Your message  has been sent to the package maintainer(s):
> bug-gnu-emacs@gnu.org
> 
> If you wish  to submit further information on this problem, please
> send it to 8288@debbugs.gnu.org.
> 
> Please do  not send mail to help-debbugs@gnu.org unless you  wish
> to report a problem with the Bug-tracking system.
> 
> -- 
> 8288: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8288
> GNU Bug Tracking  System
> Contact help-debbugs@gnu.org with problems
> 







^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#8288: Acknowledgement (vc-git slow on large repository)
  2011-03-19  2:54   ` bug#8288: Acknowledgement (vc-git slow on large repository) S Boucher
@ 2011-03-19  7:32     ` Andreas Schwab
  0 siblings, 0 replies; 5+ messages in thread
From: Andreas Schwab @ 2011-03-19  7:32 UTC (permalink / raw)
  To: S Boucher; +Cc: 8288

S Boucher <stbya@yahoo.com> writes:

> I think 'git diff-index -z HEAD -- <file>' could be replaced with 'git status -z 
> --porcelain <file>' in vc-git-state.

This requires at least git 1.7.0, but it can be replaced by --short in
older versions.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#8288: vc-git slow on large repository
  2011-03-18 19:32 bug#8288: vc-git slow on large repository S Boucher
       [not found] ` <handler.8288.B.130047675931219.ack@debbugs.gnu.org>
@ 2011-06-14 23:40 ` Jason Merrill
  2019-06-30  4:06 ` bug#8288: Acknowledgement (vc-git slow on large repository) Stefan Kangas
  2 siblings, 0 replies; 5+ messages in thread
From: Jason Merrill @ 2011-06-14 23:40 UTC (permalink / raw)
  To: 8288

This issue has been very frustrating for me with GCC git; when the 
repository isn't in the cache saving a file can cause emacs to freeze 
for about 10 seconds.  I work around it with

(defun vc-git-state-heuristic (file)
   "Just claim we're up to date."
   'up-to-date)





^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#8288: Acknowledgement (vc-git slow on large repository)
  2011-03-18 19:32 bug#8288: vc-git slow on large repository S Boucher
       [not found] ` <handler.8288.B.130047675931219.ack@debbugs.gnu.org>
  2011-06-14 23:40 ` bug#8288: vc-git slow on large repository Jason Merrill
@ 2019-06-30  4:06 ` Stefan Kangas
  2 siblings, 0 replies; 5+ messages in thread
From: Stefan Kangas @ 2019-06-30  4:06 UTC (permalink / raw)
  To: Andreas Schwab; +Cc: S Boucher, 8288

tags 8288 fixed
close 8288 26.1
quit

Andreas Schwab <schwab@linux-m68k.org> writes:
>> I think 'git diff-index -z HEAD -- <file>' could be replaced with 'git status -z
>> --porcelain <file>' in vc-git-state.
>
> This requires at least git 1.7.0, but it can be replaced by --short in
> older versions.

vc-git-state now uses the alternative faster method.

This change was made in:

24301c81 Speed up vc-git-status and make it more precise
Mon, 1 May 2017 03:30:01 +0200 (04:30 +0300)
https://git.savannah.gnu.org/gitweb/?p=emacs.git;a=commit;h=24301c8148f5f3220d7e597c73a59551cfa10eea

I'm therefore closing this bug report.  Please re-open if you
disagree.

Thanks,
Stefan Kangas





^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2019-06-30  4:06 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-18 19:32 bug#8288: vc-git slow on large repository S Boucher
     [not found] ` <handler.8288.B.130047675931219.ack@debbugs.gnu.org>
2011-03-19  2:54   ` bug#8288: Acknowledgement (vc-git slow on large repository) S Boucher
2011-03-19  7:32     ` Andreas Schwab
2011-06-14 23:40 ` bug#8288: vc-git slow on large repository Jason Merrill
2019-06-30  4:06 ` bug#8288: Acknowledgement (vc-git slow on large repository) Stefan Kangas

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).