From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.bugs Subject: bug#8771: vc-dwim problem parsing ChangeLog entries (was: Emacs bug#8771) Date: Tue, 31 May 2011 07:50:12 -0700 Organization: UCLA Computer Science Department Message-ID: <4DE50024.5020901@cs.ucla.edu> References: <4DE4861E.709@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1306853481 23796 80.91.229.12 (31 May 2011 14:51:21 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 31 May 2011 14:51:21 +0000 (UTC) Cc: 8771@debbugs.gnu.org To: bug-vc-dwim@gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue May 31 16:51:17 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QRQHr-0004uB-FT for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 May 2011 16:51:15 +0200 Original-Received: from localhost ([::1]:39507 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRQHr-0001y3-55 for geb-bug-gnu-emacs@m.gmane.org; Tue, 31 May 2011 10:51:15 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:43627) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRQHl-0001xw-3e for bug-gnu-emacs@gnu.org; Tue, 31 May 2011 10:51:13 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QRQHf-0008Ob-AU for bug-gnu-emacs@gnu.org; Tue, 31 May 2011 10:51:09 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:38198) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QRQHf-0008OR-5u for bug-gnu-emacs@gnu.org; Tue, 31 May 2011 10:51:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QRQHe-000209-7u; Tue, 31 May 2011 10:51:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Paul Eggert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 31 May 2011 14:51:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8771 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8771-submit@debbugs.gnu.org id=B8771.13068534447670 (code B ref 8771); Tue, 31 May 2011 14:51:02 +0000 Original-Received: (at 8771) by debbugs.gnu.org; 31 May 2011 14:50:44 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QRQHI-0001za-4p for submit@debbugs.gnu.org; Tue, 31 May 2011 10:50:44 -0400 Original-Received: from smtp.cs.ucla.edu ([131.179.128.62]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QRQHA-0001zJ-Ol for 8771@debbugs.gnu.org; Tue, 31 May 2011 10:50:37 -0400 Original-Received: from localhost (localhost.localdomain [127.0.0.1]) by smtp.cs.ucla.edu (Postfix) with ESMTP id F0B5339E80F2; Tue, 31 May 2011 07:50:26 -0700 (PDT) X-Virus-Scanned: amavisd-new at smtp.cs.ucla.edu Original-Received: from smtp.cs.ucla.edu ([127.0.0.1]) by localhost (smtp.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id gdWTwr4i7LfY; Tue, 31 May 2011 07:50:17 -0700 (PDT) Original-Received: from [192.168.1.10] (pool-71-189-109-235.lsanca.fios.verizon.net [71.189.109.235]) by smtp.cs.ucla.edu (Postfix) with ESMTPSA id E116239E80E0; Tue, 31 May 2011 07:50:16 -0700 (PDT) User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2.17) Gecko/20110424 Thunderbird/3.1.10 In-Reply-To: X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 31 May 2011 10:51:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46844 Archived-At: On 05/31/11 06:03, Stefan Monnier wrote: > And rather than > > * composite.c (get_composition_id, gstring_lookup_cache): > (composition_gstring_put_cache): Foobar. > > we usually write: > > * composite.c (get_composition_id, gstring_lookup_cache) > (composition_gstring_put_cache): Foobar. OK, I'll adjust that ChangeLog entry by hand. I had appended the extra colon to the first line because otherwise vc-dwim doesn't parse the ChangeLog properly. This appears to be a bug in vc-dwim so I'll send this email to bug-vc-dwim@gnu.org (the original thread is at ). For example, with vc-dwim 1.5 and the following ChangeLog: 2011-05-31 Paul Eggert Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771) * composite.c (get_composition_id, gstring_lookup_cache) (composition_gstring_put_cache): * composite.h (struct composition.hash_index): Use 'EMACS_UINT' and 'EMACS_INT' for hashes and hash indexes, instead of 'unsigned' and 'int'. vc-dwim generates the following diagnostic: vc-dwim:ChangeLog: line of unexpected form: * composite.c (get_composition_id, gstring_lookup_cache) at /home/eggert/opt/Linux-x86_64/merged/bin/vc-dwim line 991. This diagnostic means vc-dwim isn't understanding the newish ChangeLog format in the GNU coding standards . Also, that "line 991" is confusing, since it's not the line number in the ChangeLog file.