From: Paul Eggert <eggert@cs.ucla.edu>
To: bug-vc-dwim@gnu.org
Cc: 8771@debbugs.gnu.org
Subject: bug#8771: vc-dwim problem parsing ChangeLog entries (was: Emacs bug#8771)
Date: Tue, 31 May 2011 07:50:12 -0700 [thread overview]
Message-ID: <4DE50024.5020901@cs.ucla.edu> (raw)
In-Reply-To: <jwvd3izt46r.fsf-monnier+emacs@gnu.org>
On 05/31/11 06:03, Stefan Monnier wrote:
> And rather than
>
> * composite.c (get_composition_id, gstring_lookup_cache):
> (composition_gstring_put_cache): Foobar.
>
> we usually write:
>
> * composite.c (get_composition_id, gstring_lookup_cache)
> (composition_gstring_put_cache): Foobar.
OK, I'll adjust that ChangeLog entry by hand. I had appended
the extra colon to the first line because otherwise vc-dwim doesn't
parse the ChangeLog properly.
This appears to be a bug in vc-dwim so I'll send this email
to bug-vc-dwim@gnu.org (the original thread is at
<http://debbugs.gnu.org/cgi/bugreport.cgi?bug=8771#8>). For example,
with vc-dwim 1.5 and the following ChangeLog:
2011-05-31 Paul Eggert <eggert@cs.ucla.edu>
Remove arbitrary limit of 2**31 entries in hash tables. (Bug#8771)
* composite.c (get_composition_id, gstring_lookup_cache)
(composition_gstring_put_cache):
* composite.h (struct composition.hash_index):
Use 'EMACS_UINT' and 'EMACS_INT'
for hashes and hash indexes, instead of 'unsigned' and 'int'.
vc-dwim generates the following diagnostic:
vc-dwim:ChangeLog: line of unexpected form:
* composite.c (get_composition_id, gstring_lookup_cache) at /home/eggert/opt/Linux-x86_64/merged/bin/vc-dwim line 991.
This diagnostic means vc-dwim isn't understanding the newish ChangeLog
format in the GNU coding standards
<http://www.gnu.org/prep/standards/html_node/Style-of-Change-Logs.html>.
Also, that "line 991" is confusing, since it's not the line number in
the ChangeLog file.
next prev parent reply other threads:[~2011-05-31 14:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-31 6:09 bug#8771: Remove arbitrary 32-bit limit in Emacs hash tables Paul Eggert
2011-05-31 13:03 ` Stefan Monnier
2011-05-31 14:50 ` Paul Eggert [this message]
2011-05-31 21:43 ` bug#8771: [Bug-vc-dwim] vc-dwim problem parsing ChangeLog entries Jim Meyering
[not found] ` <handler.8771.B.130682219719090.ack@debbugs.gnu.org>
2011-06-02 8:05 ` bug#8771: Acknowledgement (Remove arbitrary 32-bit limit in Emacs hash tables) Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4DE50024.5020901@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=8771@debbugs.gnu.org \
--cc=bug-vc-dwim@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).