unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Daniel Colascione <dan.colascione@gmail.com>
To: Leo <sdl.web@gmail.com>
Cc: Davis Herring <herring@lanl.gov>, 8415@debbugs.gnu.org
Subject: bug#8415: 23.3.50; Extensible Emacs Registers
Date: Sun, 03 Apr 2011 10:21:45 -0700	[thread overview]
Message-ID: <4D98ACA9.6040207@gmail.com> (raw)
In-Reply-To: <m17hbb4iy9.fsf@th041156.ip.tsinghua.edu.cn>

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

Hi Leo,

On 4/3/11 5:29 AM, Leo wrote:
> I would like to propose the following patch that makes the register
> system easier to hook into. With this change, for example, if one wants
> to make a command to save a keyboard macro to a register. There is no
> need to change register.el. 3rd party libraries such as undo-tree.el can
> add registers of undo state that one can jump to with C-x r j.
> 
> With this change, register is now a compound data structure. I have also
> removed one inconsistent use of the argument REGISTER. In the new code
> it always refers to the register object and never the name.


Thanks for doing this work.  Why is window configuration special-cased
instead of going through the function hooking mechanism?  "Any
customized data" might be parsed as referring to the customize
mechanism; "any value" would suffice.  increment and append don't have
extension points.  It'd be reasonable for a non-text register type to
support these operations in some sense.

Other than that, it good okay to me.

Thanks,
Daniel Colascione


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

  reply	other threads:[~2011-04-03 17:21 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-03 12:29 bug#8415: 23.3.50; Extensible Emacs Registers Leo
2011-04-03 17:21 ` Daniel Colascione [this message]
2011-04-04  1:29   ` Leo
2011-04-04 14:29 ` Stefan Monnier
2011-04-04 17:37   ` Leo
2011-04-04 22:19     ` Stefan Monnier
2011-04-04 22:27       ` Daniel Colascione
2011-04-05  1:41         ` Stefan Monnier
2011-04-05  1:49           ` Daniel Colascione
2011-04-05  3:07             ` Stefan Monnier
2011-04-05  5:42               ` Leo
2011-04-05 13:50                 ` Stefan Monnier
2011-04-06  5:00                   ` Leo
2011-04-06 15:38                     ` Stefan Monnier
2011-04-07  3:13                       ` Leo
2011-04-09  1:25                         ` Stefan Monnier
2011-06-23  8:11                           ` Leo
2011-06-25 13:19                             ` Stefan Monnier
2011-06-26  6:42                               ` Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4D98ACA9.6040207@gmail.com \
    --to=dan.colascione@gmail.com \
    --cc=8415@debbugs.gnu.org \
    --cc=herring@lanl.gov \
    --cc=sdl.web@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).