From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Ken Brown Newsgroups: gmane.emacs.bugs Subject: bug#8267: Acknowledgement (unexec FIXME in src/emacs.c) Date: Thu, 17 Mar 2011 15:01:01 -0400 Message-ID: <4D825A6D.6070402@cornell.edu> References: <4D815239.3080509@cs.ucla.edu> <4D823CB7.3000209@cs.ucla.edu> <4D824CBA.5000703@cornell.edu> <4D8256BE.4060309@cs.ucla.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1300388862 3636 80.91.229.12 (17 Mar 2011 19:07:42 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 17 Mar 2011 19:07:42 +0000 (UTC) Cc: "8267@debbugs.gnu.org" <8267@debbugs.gnu.org> To: Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Mar 17 20:07:35 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0IXj-0001Ci-Fp for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Mar 2011 20:07:34 +0100 Original-Received: from localhost ([127.0.0.1]:49233 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0IXh-0006B1-Nw for geb-bug-gnu-emacs@m.gmane.org; Thu, 17 Mar 2011 15:07:29 -0400 Original-Received: from [140.186.70.92] (port=44939 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Q0IXJ-0005xe-8H for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2011 15:07:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Q0IXI-0003mc-B5 for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2011 15:07:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:49976) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Q0IXI-0003mY-9e for bug-gnu-emacs@gnu.org; Thu, 17 Mar 2011 15:07:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1Q0ISQ-0007vR-7H; Thu, 17 Mar 2011 15:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Ken Brown Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 17 Mar 2011 19:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8267 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8267-submit@debbugs.gnu.org id=B8267.130038847430405 (code B ref 8267); Thu, 17 Mar 2011 19:02:02 +0000 Original-Received: (at 8267) by debbugs.gnu.org; 17 Mar 2011 19:01:14 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0IRd-0007uM-Es for submit@debbugs.gnu.org; Thu, 17 Mar 2011 15:01:13 -0400 Original-Received: from granite1.mail.cornell.edu ([128.253.83.141] helo=authusersmtp.mail.cornell.edu) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Q0IRa-0007u9-QD for 8267@debbugs.gnu.org; Thu, 17 Mar 2011 15:01:12 -0400 Original-Received: from [128.84.234.248] (dhcp248.math.cornell.edu [128.84.234.248]) (authenticated bits=0) by authusersmtp.mail.cornell.edu (8.14.4/8.12.10) with ESMTP id p2HJ14OB021263 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT); Thu, 17 Mar 2011 15:01:04 -0400 (EDT) User-Agent: Mozilla/5.0 (Windows; U; Windows NT 6.1; en-US; rv:1.9.2.15) Gecko/20110303 Thunderbird/3.1.9 In-Reply-To: <4D8256BE.4060309@cs.ucla.edu> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 17 Mar 2011 15:02:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:45118 Archived-At: On 3/17/2011 2:45 PM, Paul Eggert wrote: > On 03/17/2011 11:02 AM, Ken Brown wrote: >> On 3/17/2011 12:54 PM, Paul Eggert wrote: >>> I've committed a patch for this in bzr103679. >> >> In unexec.h you declare unexec() to return void, but in several of the unexec*.c files it has a return type of int. > > Thanks for catching that. I didn't notice that, since I built > on an implementation where it returns void. I changed the > other implementations to match the new header (bzr 103680). OK, but your change removes a lot of "returns" that shouldn't be removed. I think the function should still return in those places; it's just that it shouldn't return a value.