unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: Paul Eggert <eggert@cs.ucla.edu>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: 7859@debbugs.gnu.org, bug-gnulib <bug-gnulib@gnu.org>,
	7856@debbugs.gnu.org, emacs-devel@gnu.org
Subject: bug#7859: syncing Emacs from sources maintained elsewhere
Date: Wed, 19 Jan 2011 23:51:12 -0800	[thread overview]
Message-ID: <4D37E970.2060803__36329.8911638141$1295510108$gmane$org@cs.ucla.edu> (raw)
In-Reply-To: <4D37D9FD.3050805@swipnet.se>

On 01/19/2011 10:45 PM, Jan Djärv wrote:
> /* config.h #define:s malloc/realloc/free and then includes stdlib.h.
>    We want the undefined versions, but if config.h includes stdlib.h
>    with the #define:s in place, the prototypes will be wrong and we get
>    warnings.  To prevent that, include stdlib.h before config.h.  */

OK, I see.  There's a better way, one that doesn't potentially mess up
the ABI.  Namely, Emacs can supply a stdlib.h wrapper that #defines
malloc/realloc/free the way we like.  gnulib already does
that, but Emacs doesn't use gnulib's stdlib.h wrapper.
At some point, perhaps Emacs will, and then we can look into
this issue again.

Is stdlib.h the only include file that has the problem?
If so, I suggest modifying unexmacosx.c to include <stdlib.h>
first, <config.h> second, and everything else after that.
That should lessen the likelihood of an ABI mismatch.

If not, then what other include files have the problem?
This issue may come up if we add more wrappers from gnulib.





  parent reply	other threads:[~2011-01-20  7:51 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <4D2BA939.5090903@cs.ucla.edu>
     [not found] ` <4D34A88F.4080400@cs.ucla.edu>
     [not found]   ` <vz1aaiyjzcq.fsf@gmail.com>
     [not found]     ` <E1PfDM1-0003kg-V2@fencepost.gnu.org>
     [not found]       ` <4D35D842.5030003@cs.ucla.edu>
     [not found]         ` <cksjwp7kq7.fsf@fencepost.gnu.org>
2011-01-19  6:04           ` bug#7859: syncing Emacs from sources maintained elsewhere Paul Eggert
2011-01-19  6:04           ` bug#7856: " Paul Eggert
     [not found]           ` <4D367F0B.3040808@cs.ucla.edu>
     [not found]             ` <4D368D16.7020702@swipnet.se>
     [not found]               ` <25y66hjmiu.fsf@fencepost.gnu.org>
2011-01-19 10:38                 ` bug#7859: " Paul Eggert
2011-01-19 10:38                 ` bug#7856: " Paul Eggert
     [not found]                 ` <4D36BF43.3050007@cs.ucla.edu>
2011-01-19 15:54                   ` bug#7856: bug#7859: " Jan Djärv
2011-01-19 15:54                   ` Jan Djärv
     [not found]                   ` <4D370928.1040601@swipnet.se>
2011-01-19 23:44                     ` Paul Eggert
2011-01-19 23:44                     ` bug#7856: " Paul Eggert
     [not found]                     ` <4D377768.8070504@cs.ucla.edu>
2011-01-20  0:21                       ` Eli Zaretskii
2011-01-20  6:45                       ` bug#7856: " Jan Djärv
2011-01-20  6:45                       ` Jan Djärv
     [not found]                       ` <4D37D9FD.3050805@swipnet.se>
2011-01-20  7:51                         ` bug#7856: " Paul Eggert
2011-01-20  7:51                         ` Paul Eggert [this message]
     [not found]                         ` <4D37E970.2060803@cs.ucla.edu>
2011-01-20 11:26                           ` Jan D.
2011-01-20 11:26                           ` bug#7856: " Jan D.
2011-01-20  0:27                   ` bug#7856: " Eric Blake
2011-01-20  0:27                   ` bug#7859: " Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='4D37E970.2060803__36329.8911638141$1295510108$gmane$org@cs.ucla.edu' \
    --to=eggert@cs.ucla.edu \
    --cc=7856@debbugs.gnu.org \
    --cc=7859@debbugs.gnu.org \
    --cc=bug-gnulib@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=jan.h.d@swipnet.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).