From: Eric Blake <eblake@redhat.com>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org, bug-gnulib <bug-gnulib@gnu.org>,
7856@debbugs.gnu.org, 7859@debbugs.gnu.org
Subject: bug#7859: syncing Emacs from sources maintained elsewhere
Date: Wed, 19 Jan 2011 17:27:47 -0700 [thread overview]
Message-ID: <4D378183.8030001__1737.52762279964$1295484900$gmane$org@redhat.com> (raw)
In-Reply-To: <4D36BF43.3050007@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 988 bytes --]
On 01/19/2011 03:38 AM, Paul Eggert wrote:
> * unexmacosx.c includes the Gnulib <unistd.h>.
That's always a bug to include any gnulib-provided header prior to
<config.h>.
>
> * And when Gnulib <getopt.h> declares a 'struct option', this clashes
> with the 'struct option' declared in the system getopt.h.
And this is a known symptom of violating the above constraint.
>
> PS. This all seems to be a case where we should be using Gnulib's
> identifier replacement mechanism, but I don't understand it that
> well and if memory serves it doesn't work with struct tags anyway.
We've managed to modernize other headers to properly declare replacement
structs exactly once; it is merely a matter of someone having enough
time to modernize the gnulib getopt module to use modern constructs
rather than abusing config.h to define an rpl_ prefix.
--
Eric Blake eblake@redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]
prev parent reply other threads:[~2011-01-20 0:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <4D2BA939.5090903@cs.ucla.edu>
[not found] ` <4D34A88F.4080400@cs.ucla.edu>
[not found] ` <vz1aaiyjzcq.fsf@gmail.com>
[not found] ` <E1PfDM1-0003kg-V2@fencepost.gnu.org>
[not found] ` <4D35D842.5030003@cs.ucla.edu>
[not found] ` <cksjwp7kq7.fsf@fencepost.gnu.org>
2011-01-19 6:04 ` bug#7859: syncing Emacs from sources maintained elsewhere Paul Eggert
2011-01-19 6:04 ` bug#7856: " Paul Eggert
[not found] ` <4D367F0B.3040808@cs.ucla.edu>
[not found] ` <4D368D16.7020702@swipnet.se>
[not found] ` <25y66hjmiu.fsf@fencepost.gnu.org>
2011-01-19 10:38 ` Paul Eggert
2011-01-19 10:38 ` bug#7859: " Paul Eggert
[not found] ` <4D36BF43.3050007@cs.ucla.edu>
2011-01-19 15:54 ` Jan Djärv
2011-01-19 15:54 ` bug#7856: " Jan Djärv
[not found] ` <4D370928.1040601@swipnet.se>
2011-01-19 23:44 ` Paul Eggert
2011-01-19 23:44 ` Paul Eggert
[not found] ` <4D377768.8070504@cs.ucla.edu>
2011-01-20 0:21 ` Eli Zaretskii
2011-01-20 6:45 ` bug#7856: " Jan Djärv
2011-01-20 6:45 ` Jan Djärv
[not found] ` <4D37D9FD.3050805@swipnet.se>
2011-01-20 7:51 ` bug#7856: " Paul Eggert
2011-01-20 7:51 ` Paul Eggert
[not found] ` <4D37E970.2060803@cs.ucla.edu>
2011-01-20 11:26 ` Jan D.
2011-01-20 11:26 ` bug#7856: " Jan D.
2011-01-20 0:27 ` bug#7856: " Eric Blake
2011-01-20 0:27 ` Eric Blake [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/emacs/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='4D378183.8030001__1737.52762279964$1295484900$gmane$org@redhat.com' \
--to=eblake@redhat.com \
--cc=7856@debbugs.gnu.org \
--cc=7859@debbugs.gnu.org \
--cc=bug-gnulib@gnu.org \
--cc=eggert@cs.ucla.edu \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/emacs.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).