From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: bug#7533: 24.0.50; `dired-mark-pop-up': delete frame afterwards if `pop-up-frames' Date: Thu, 02 Dec 2010 20:05:17 +0100 Message-ID: <4CF7EDED.5090500@gmx.at> References: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: dough.gmane.org 1291317330 27660 80.91.229.12 (2 Dec 2010 19:15:30 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 2 Dec 2010 19:15:30 +0000 (UTC) Cc: 7533@debbugs.gnu.org To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu Dec 02 20:15:26 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1POEck-0006Qk-Sw for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Dec 2010 20:15:23 +0100 Original-Received: from localhost ([127.0.0.1]:55973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POEck-0008Oq-6X for geb-bug-gnu-emacs@m.gmane.org; Thu, 02 Dec 2010 14:15:22 -0500 Original-Received: from [140.186.70.92] (port=34996 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1POEcb-0008Ld-Hg for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 14:15:16 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1POEcX-0008Ct-32 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 14:15:13 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:41085) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1POEcW-0008Cj-W9 for bug-gnu-emacs@gnu.org; Thu, 02 Dec 2010 14:15:09 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1POENv-0003NR-2r; Thu, 02 Dec 2010 14:00:03 -0500 X-Loop: help-debbugs@gnu.org Resent-From: martin rudalics Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 02 Dec 2010 19:00:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 7533 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 7533-submit@debbugs.gnu.org id=B7533.129131638512922 (code B ref 7533); Thu, 02 Dec 2010 19:00:02 +0000 Original-Received: (at 7533) by debbugs.gnu.org; 2 Dec 2010 18:59:45 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1POENd-0003MN-Bg for submit@debbugs.gnu.org; Thu, 02 Dec 2010 13:59:45 -0500 Original-Received: from mailout-de.gmx.net ([213.165.64.22] helo=mail.gmx.net) by debbugs.gnu.org with smtp (Exim 4.69) (envelope-from ) id 1POENa-0003M0-7A for 7533@debbugs.gnu.org; Thu, 02 Dec 2010 13:59:43 -0500 Original-Received: (qmail invoked by alias); 02 Dec 2010 19:05:23 -0000 Original-Received: from 62-47-51-60.adsl.highway.telekom.at (EHLO [62.47.51.60]) [62.47.51.60] by mail.gmx.net (mp068) with SMTP; 02 Dec 2010 20:05:23 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1+02CFQrti01LZEUo6oY7DMFis+UdGNTtDBbcUkj2 mmZIRZ83v690As User-Agent: Thunderbird 2.0.0.21 (Windows/20090302) In-Reply-To: <90E09641E9264B37932D2315E5E7E2EA@us.oracle.com> X-Y-GMX-Trusted: 0 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Thu, 02 Dec 2010 14:00:03 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:42084 Archived-At: > (save-window-excursion > (dired-pop-to-buffer bufname) > (apply function args) > (if (one-window-p) (delete-frame) (delete-window))) ; <===== NEW This would be funny when `pop-up-frames' is nil and a window gets reused for showing the *Deletions* buffer. In particular if that window is the only window on its frame ;-) BTW the `save-window-excursion' is completely useless when you pop up a new frame. > The important thing, for me, is that the frame that was created just to > show the files that will be deleted (or whatever) goes away. It should > be only a _temporary_ frame because its only raison d'etre is as part of > the deletion etc. _dialog_. Here I have a simple function called `quit-restore-window' which does exactly that. > [Martin will explain that a different test from `one-window-p' is more > appropriate. ;-) IIRC, he generally prefers something like this to > (one-window-p win): (eq win (frame-root-window (window-frame win))).] Because `one-window-p' calls `next-window' which I don't like. See the recent discussion about `loop' endlessly cycling over windows. martin