bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX

bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX

[Jakub Turski]

It's not a bug per se, rather a feature request.
Would it be possible to include this patch:
http://lists.aquamacs.org/pipermail/aquamacs-devel/2009-November/003853.html
in Gnu Emacs? It's only relevant for OSX, but makes life easier for
anyone who wants to use Emacs under OSX and uses a keyboard layout that
uses right Alt key as a modifier to input special characters. This is an
Aquamacs patch, and Aquamacs allows this:

;; Make right Meta a system modifier.
(setq ns-right-alternate-modifier nil)

which results in left Alt being interpreted by Aquamacs as Meta, and
right Alt being interpreted by operating system as keyboard
modifier. This allows me to use Polish keyboard layout without resorting
to unusual method of inputting Polish characters. It would be good if
other users, especially those that don't want to use Aquamacs because of
some of its modifications, can use this feature.

I've tried to naively apply this patch to current 23.2 sources, but
failed - apparently it has diverged too much by now. I don't think I
have both skills and time needed to modify this patch, but it looks
relatively simple, provided you know your way around Emacs source code.

Is there a chance to port and include this feature?

Thanks,

KT.

In GNU Emacs 23.2.50.2 (x86_64-apple-darwin10.4.0, NS apple-appkit-1038.32)
 of 2010-10-02 on imacoob.nerv.local
Windowing system distributor `Apple', version 10.3.1038
configured using `configure  '--with-ns''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: pl_PL.UTF-8
  value of $LC_CTYPE: pl_PL.UTF-8
  value of $LC_MESSAGES: C
  value of $LC_MONETARY: en_IE.utf-8
  value of $LC_NUMERIC: en_IE.utf-8
  value of $LC_TIME: en_IE.utf-8
  value of $LANG: en_IE.UTF-8
  value of $XMODIFIERS: nil
  locale-coding-system: utf-8-unix
  default enable-multibyte-characters: t

Major mode: Fundamental

Minor modes in effect:
  global-whitespace-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x 1 M-x r e p o r t - e m a <tab> <return>

Recent messages:
For information about GNU Emacs and the GNU system, type C-h C-a.

Load-path shadows:
None found.

Features:
(shadow sort mail-extr message ecomplete rfc822 mml mml-sec
password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1
hex-util hashcash mail-utils emacsbug warnings disp-table whitespace
tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win easymenu
tool-bar dnd fontset image fringe lisp-mode register page menu-bar
rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock
syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
romanian slovak czech european ethiopic indian cyrillic chinese
case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
minibuffer faces cus-face files text-properties overlay md5 base64
format env code-pages mule custom widget hashtable-print-readable
backquote make-network-process ns multi-tty emacs)

bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX

[Jan Djärv]

I commited the same functionality in the emacs-23 branch.  The patch you refer 
to makes none mean something else for right alt (follow left alt) than it does 
for the left alt (pass to system).  This is inconsistent, so I kept none to 
mean pass to system, and made a new value, left, to mean follow the left alt key.

	Jan D.

Jakub Turski skrev 2010-10-02 17.41:
> It's not a bug per se, rather a feature request.
> Would it be possible to include this patch:
> http://lists.aquamacs.org/pipermail/aquamacs-devel/2009-November/003853.html
> in Gnu Emacs? It's only relevant for OSX, but makes life easier for
> anyone who wants to use Emacs under OSX and uses a keyboard layout that
> uses right Alt key as a modifier to input special characters. This is an
> Aquamacs patch, and Aquamacs allows this:
>
> ;; Make right Meta a system modifier.
> (setq ns-right-alternate-modifier nil)
>
> which results in left Alt being interpreted by Aquamacs as Meta, and
> right Alt being interpreted by operating system as keyboard
> modifier. This allows me to use Polish keyboard layout without resorting
> to unusual method of inputting Polish characters. It would be good if
> other users, especially those that don't want to use Aquamacs because of
> some of its modifications, can use this feature.
>
> I've tried to naively apply this patch to current 23.2 sources, but
> failed - apparently it has diverged too much by now. I don't think I
> have both skills and time needed to modify this patch, but it looks
> relatively simple, provided you know your way around Emacs source code.
>
> Is there a chance to port and include this feature?
>
> Thanks,
>
> KT.
>
> In GNU Emacs 23.2.50.2 (x86_64-apple-darwin10.4.0, NS apple-appkit-1038.32)
>   of 2010-10-02 on imacoob.nerv.local
> Windowing system distributor `Apple', version 10.3.1038
> configured using `configure  '--with-ns''
>
> Important settings:
>    value of $LC_ALL: nil
>    value of $LC_COLLATE: pl_PL.UTF-8
>    value of $LC_CTYPE: pl_PL.UTF-8
>    value of $LC_MESSAGES: C
>    value of $LC_MONETARY: en_IE.utf-8
>    value of $LC_NUMERIC: en_IE.utf-8
>    value of $LC_TIME: en_IE.utf-8
>    value of $LANG: en_IE.UTF-8
>    value of $XMODIFIERS: nil
>    locale-coding-system: utf-8-unix
>    default enable-multibyte-characters: t
>
> Major mode: Fundamental
>
> Minor modes in effect:
>    global-whitespace-mode: t
>    tooltip-mode: t
>    mouse-wheel-mode: t
>    menu-bar-mode: t
>    file-name-shadow-mode: t
>    global-font-lock-mode: t
>    auto-encryption-mode: t
>    auto-compression-mode: t
>    line-number-mode: t
>    transient-mark-mode: t
>
> Recent input:
> C-x 1 M-x r e p o r t - e m a<tab>  <return>
>
> Recent messages:
> For information about GNU Emacs and the GNU system, type C-h C-a.
>
> Load-path shadows:
> None found.
>
> Features:
> (shadow sort mail-extr message ecomplete rfc822 mml mml-sec
> password-cache mm-decode mm-bodies mm-encode mailcap mail-parse rfc2231
> rfc2047 rfc2045 qp ietf-drums mailabbrev nnheader gnus-util netrc
> time-date mm-util mail-prsvr gmm-utils wid-edit mailheader canlock sha1
> hex-util hashcash mail-utils emacsbug warnings disp-table whitespace
> tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win easymenu
> tool-bar dnd fontset image fringe lisp-mode register page menu-bar
> rfn-eshadow timer select scroll-bar mldrag mouse jit-lock font-lock
> syntax facemenu font-core frame cham georgian utf-8-lang misc-lang
> vietnamese tibetan thai tai-viet lao korean japanese hebrew greek
> romanian slovak czech european ethiopic indian cyrillic chinese
> case-table epa-hook jka-cmpr-hook help simple abbrev loaddefs button
> minibuffer faces cus-face files text-properties overlay md5 base64
> format env code-pages mule custom widget hashtable-print-readable
> backquote make-network-process ns multi-tty emacs)
>
>

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Jakub Turski]

> I commited the same functionality in the emacs-23 branch.  The patch you refer to makes none mean something else for right alt (follow left alt) than it does for the left alt (pass to system).  This is inconsistent, so I kept none to mean pass to system, and made a new value, left, to mean follow the left alt key.
Can you please point me to relevant commit, so I can get the right
branch, compile and test that?

Thanks,

KT.

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Jan Djärv]

Jakub Turski skrev 2010-10-12 00.20:
>> I commited the same functionality in the emacs-23 branch.  The patch you refer to makes none mean something else for right alt (follow left alt) than it does for the left alt (pass to system).  This is inconsistent, so I kept none to mean pass to system, and made a new value, left, to mean follow the left alt key.
> Can you please point me to relevant commit, so I can get the right
> branch, compile and test that?
>

Use
% bzr branch http://bzr.savannah.gnu.org/r/emacs/emacs-23

to get that branch.  Also see http://savannah.gnu.org/projects/emacs/.
The relevant revno is 100102.

	Jan D.

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Eli Zaretskii]

> Date: Wed, 13 Oct 2010 10:05:31 +0200
> From: Jan Djärv <jan.h.d@swipnet.se>
> Cc: 7150@debbugs.gnu.org
> 
> > Can you please point me to relevant commit, so I can get the right
> > branch, compile and test that?
> >
> 
> Use
> % bzr branch http://bzr.savannah.gnu.org/r/emacs/emacs-23

I think it is

  bzr branch bzr://bzr.savannah.gnu.org/emacs/emacs-23

(i.e. without the "r" part and with "bzr" instead of "http").

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Jan Djärv]

2010-10-13 14:18, Eli Zaretskii skrev:
>> Date: Wed, 13 Oct 2010 10:05:31 +0200
>> From: Jan Djärv<jan.h.d@swipnet.se>
>> Cc: 7150@debbugs.gnu.org
>>
>>> Can you please point me to relevant commit, so I can get the right
>>> branch, compile and test that?
>>>
>>
>> Use
>> % bzr branch http://bzr.savannah.gnu.org/r/emacs/emacs-23
>
> I think it is
>
>    bzr branch bzr://bzr.savannah.gnu.org/emacs/emacs-23
>
> (i.e. without the "r" part and with "bzr" instead of "http").

Well, http: with r works as does bzr: without r.  Take your pick :-).
Maybe bzr is faster if you later are going to update the tree, I haven't 
tested.  For the inital download they are the same (i.e. slow).

	Jan D.

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Andreas Schwab]

Eli Zaretskii <eliz@gnu.org> writes:

>> Use
>> % bzr branch http://bzr.savannah.gnu.org/r/emacs/emacs-23
>
> I think it is
>
>   bzr branch bzr://bzr.savannah.gnu.org/emacs/emacs-23

Both are correct, albeit the latter is faster, but may not work through
firewalls.

Andreas.

-- 
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756  01D3 44D5 214B 8276 4ED5
"And now for something completely different."

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Jakub Turski]

> Use
> % bzr branch http://bzr.savannah.gnu.org/r/emacs/emacs-23
> The relevant revno is 100102.
I can confirm it really works as expected. Well, at least as I'd
expect it to work :)
I take it that this change will be included in 23.3?

KT.

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Jan Djärv]

Jakub Turski skrev 2010-10-14 22.56:
>> Use
>> % bzr branch http://bzr.savannah.gnu.org/r/emacs/emacs-23
>> The relevant revno is 100102.
> I can confirm it really works as expected. Well, at least as I'd
> expect it to work :)
> I take it that this change will be included in 23.3?
>

Yes, that tree will become 23.3.

	Jan D.

bug#7150: closed (Re: bug#7150: 23.2.50; Include patch for distinguishing between left and right Alt keys on OSX)

[Esa Peuha]

>Well, http: with r works as does bzr: without r.  Take your pick :-).
>Maybe bzr is faster if you later are going to update the tree, I haven't
>tested.  For the inital download they are the same (i.e. slow).

People who only want the latest revision (ie. not the full history)
can use "bzr checkout --lightweight" instead of "bzr branch" to save
both disk space and transfer time (at least initially, don't know
about updates). Maybe http://savannah.gnu.org/bzr/?group=emacs could
mention this possibility.

bug#7150: Distinguishing between left/right modifier keys in OSX

[Robert Clancy]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

Would it be possible to include this patch
http://lists.aquamacs.org/pipermail/aquamacs-devel/2009-December/003890.html
which allows OSX users to set right modifier keys to be (for example)  
meta? It is extremely useful for someone who uses OSX.

Thanks,
Rob

[-- Attachment #2: Type: text/html, Size: 486 bytes --]

bug#7150: Distinguishing between left/right modifier keys in OSX

[Jan Djärv]

Can you file a separate bug for this and explicitly spell out what you wish 
without referring to a patch?

	Jan D.


Robert Clancy skrev 2010-11-19 16.00:
> Would it be possible to include this patch
> http://lists.aquamacs.org/pipermail/aquamacs-devel/2009-December/003890.html
> which allows OSX users to set right modifier keys to be (for example) meta? It
> is extremely useful for someone who uses OSX.
>
> Thanks,
> Rob