unofficial mirror of bug-gnu-emacs@gnu.org 
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yacoob@gmail.com, 7348@debbugs.gnu.org
Subject: bug#7348: 23.2.50; Emacs crashes on fast window resize with scrollbars on under OSX
Date: Tue, 09 Nov 2010 08:43:20 +0100	[thread overview]
Message-ID: <4CD8FB98.8080706@gmx.at> (raw)
In-Reply-To: <831v6vobys.fsf@gnu.org>

 > The only thing I see that uses selected_window and is done between
 > this line:
 >
 >   ++redisplaying_p;
 >
 > and the 1st call to do_pending_window_change is this call:
 >
 >   reconsider_clip_changes (w, current_buffer);
 >
 > We could simply call reconsider_clip_changes again if we detect that
 > the selected_window changed after the call to do_pending_window_change.

I suppose that would be sufficient.

 > The second call to do_pending_window_change is conditioned on
 > must_finish being zero, which I think cannot happen when this
 > situation hits.

Well I thought must_finish being non-zero means we must neglect pending
changes while must_finish zero means we are allowed to do them.  But I
don't understand redisplay_internal at all.

 > And the third call to do_pending_window_change already goes back to
 > retry anyway.

And if for some reason it doesn't this should not harm either.

 > So maybe there's no problem in updating the value of w in this case.

In my branch I try to avoid that frame size changes may delete the
selected window.  But it's non-trivial to put such behavior into the
trunk code.

Anyway, if you're going to fix this please try putting a comment there
how pause, must_finish and windows_or_buffers_changed interact and what
the entire minibuffer/echo area stuff is about.

martin





  reply	other threads:[~2010-11-09  7:43 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-06 21:20 bug#7348: 23.2.50; Emacs crashes on fast window resize with scrollbars on under OSX Jakub Turski
2010-11-07  3:18 ` YAMAMOTO Mitsuharu
2010-11-07 10:34   ` martin rudalics
2010-11-08  1:43     ` YAMAMOTO Mitsuharu
2010-11-08 10:07       ` martin rudalics
2010-11-08 19:24         ` Eli Zaretskii
2010-11-09  7:43           ` martin rudalics [this message]
2010-11-09 16:57             ` Eli Zaretskii
2010-11-09 17:52               ` martin rudalics
2010-11-09 18:49                 ` Eli Zaretskii
2010-11-10  7:18                   ` martin rudalics
2011-02-07 17:26                     ` Jakub Turski
2011-02-08  4:57                       ` Eli Zaretskii
2011-02-08  7:23                         ` Jan Djärv
2010-11-07 11:22   ` Jan Djärv
2010-11-07 19:05     ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/emacs/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4CD8FB98.8080706@gmx.at \
    --to=rudalics@gmx.at \
    --cc=7348@debbugs.gnu.org \
    --cc=eliz@gnu.org \
    --cc=yacoob@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/emacs.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).